Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove LegacyIngestEvent and InitialOrigin functionality #759

Closed
donaldgray opened this issue Mar 12, 2024 · 2 comments · Fixed by #772
Closed

Remove LegacyIngestEvent and InitialOrigin functionality #759

donaldgray opened this issue Mar 12, 2024 · 2 comments · Fixed by #772
Assignees
@griffri
Labels
jira marks issue for crossposting to JIRA sustainability

Comments

@donaldgray
Copy link
Member

donaldgray commented Mar 12, 2024 •
edited
Loading

The following functionality is no longer required and can be removed:

  • LegacyIngestEvent and all usages. This was used for testing Deliverator-API -> Protagonist-Engine interactions to validate old/new behaviour. At one point there was a possibility of rolling out Protagoinst-Engine while still using Deliverator-API but this won't happen now. UseLegacyEngineMessage appSetting controls whether API uses this format so can also be removed.
  • "InitialOrigin" usage in Portal. This field was removed in Update Engine HydrateAssetPolicies() method for delivery channel model #622/API sends minimal payload to Engine #750 but is still available in CSV upload.
@donaldgray donaldgray added sustainability jira marks issue for crossposting to JIRA labels Mar 12, 2024
@griffri
Copy link
Contributor

griffri commented Mar 12, 2024 •
edited
Loading

When removing LegacyIngestEvent support, should IngestAssetRequest also be changed so that it only contains a AssetId?
The full asset is currently only used for the legacy Engine.

@tomcrane tomcrane changed the title Remove unused functionality Remove LegacyIngestEvent and InitialOrigin functionality Mar 14, 2024
@donaldgray
Copy link
Member Author

When removing LegacyIngestEvent support, should IngestAssetRequest also be changed so that it only contains a AssetId?
The full asset is currently only used for the legacy Engine.

This was fixed in #763

@griffri griffri mentioned this issue Mar 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@griffri griffri

Labels
jira marks issue for crossposting to JIRA sustainability
Projects
Delivery Channels
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove deprecated functionality (LegacyIngestEvent & InitialOrigin) dlcs/protagonist
2 participants
@donaldgray @griffri