Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated functionality (LegacyIngestEvent & InitialOrigin) #772

Merged
merged 4 commits into from
Mar 22, 2024

Conversation

griffri
Copy link
Contributor

@griffri griffri commented Mar 22, 2024

Resolves #759

InitialOrigin is no longer expected by the Portal batch uploader when reading a CSV file. The sample file available for download has also been updated to reflect this change.

Legacy payload support and its associated tests and configuration have been removed from Engine.

@griffri griffri changed the title Removed deprecated functionality (LegacyIngestEvent & InitialOrigin) Remove deprecated functionality (LegacyIngestEvent & InitialOrigin) Mar 22, 2024
@griffri griffri marked this pull request as ready for review March 22, 2024 11:31
@griffri griffri requested a review from a team as a code owner March 22, 2024 11:31
Copy link
Member

@donaldgray donaldgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - there's still a mention of legacy handling in engine readme - that should be removed too.

@griffri griffri requested a review from donaldgray March 22, 2024 13:44
@griffri griffri merged commit 15ef522 into develop Mar 22, 2024
9 checks passed
@griffri griffri deleted the remove/initialorigin_legacyingest branch March 22, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove LegacyIngestEvent and InitialOrigin functionality
2 participants