Update logic for Orchestrator and Engine to determine if an Asset has a particular deliveryChannel #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donaldgray
reviewed
Mar 14, 2024
src/protagonist/Engine.Tests/Data/EngineAssetRepositoryTests.cs
Outdated
Show resolved
Hide resolved
JackLewis-digirati
changed the title
donaldgray
approved these changes
Mar 15, 2024
JackLewis-digirati
force-pushed
the
feature/determineDeliveryChannel
branch
from
a4ceb3d
to
f266ebb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #621 and wdc-40
This PR updates the engine and orchestrator to use
ImageDeliveryChannelsto determine delivery channels, as opposed to theDeliveryChannelsarray.The
IngestAssetrequest has been modified to only require an asset id, instead of the full assetThis pull request also modifies the
engineClientin the API to throw an error if a legacy ingest attempt is made, in preparation for removal of this feature.