Implementing default delivery channel matching #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donaldgray
reviewed
Feb 23, 2024
There was a problem hiding this comment.
It might be worth moving the stuff for matching default delivery channels to it's own class for ease of testing - even into IDefaultDeliveryChannelRepository so that can be more than just a caching layer to DB - may be able to alter that so it doesn't return the whole list and does all matching internally. Once it's in there we can write tests against it in isolation to confirm logic. From there it will make it easy to refactor as long as the tests pass.
Using 3 methods and multiple dictionarys feels slightly overly complex and difficult to follow for how the default matching is done but I could well be overlooking something but if this works and it's encapsulated into a tested class then it's easy to refactor.
src/protagonist/DLCS.Repository/DeliveryChannels/DefaultDeliveryChannelRepository.cs
Outdated
Show resolved
Hide resolved
src/protagonist/DLCS.Repository/DeliveryChannels/DefaultDeliveryChannelRepository.cs
Outdated
Show resolved
Hide resolved
src/protagonist/DLCS.Repository/DeliveryChannels/DefaultDeliveryChannelRepository.cs
Outdated
Show resolved
Hide resolved
JackLewis-digirati
force-pushed
the
feature/implementDefaultDeliveryChannels
branch
from
ee05064
to
13c8fca
Compare
donaldgray
reviewed
Feb 27, 2024
src/protagonist/DLCS.Repository.Tests/DLCS.Repository.Tests.csproj
Outdated
Show resolved
Hide resolved
src/protagonist/API/Features/DeliveryChannels/DeliveryChannelPolicyRepository.cs
Outdated
Show resolved
Hide resolved
src/protagonist/API.Tests/Features/Images/Ingest/AssetProcessorTest.cs
Outdated
Show resolved
Hide resolved
donaldgray
approved these changes
Feb 28, 2024
src/protagonist/API.Tests/Features/DeliveryChannels/DefaultDeliveryChannelRepositoryTests.cs
Outdated
Show resolved
Hide resolved
src/protagonist/API.Tests/Features/DeliveryChannels/DefaultDeliveryChannelRepositoryTests.cs
Outdated
Show resolved
Hide resolved
src/protagonist/API/Features/DeliveryChannels/DefaultDeliveryChannelRepository.cs
Outdated
Show resolved
Hide resolved
src/protagonist/API/Features/DeliveryChannels/DefaultDeliveryChannelRepository.cs
Outdated
Show resolved
Hide resolved
src/protagonist/API/Features/DeliveryChannels/DeliveryChannelPolicyRepository.cs
Outdated
Show resolved
Hide resolved
griffri
reviewed
Feb 28, 2024
src/protagonist/API.Tests/Features/DeliveryChannels/DefaultDeliveryChannelRepositoryTests.cs
Outdated
Show resolved
Hide resolved
griffri
approved these changes
Mar 1, 2024
JackLewis-digirati
force-pushed
the
feature/implementDefaultDeliveryChannels
branch
from
e2d75a7
to
f23988c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #625
This pull request implements the ability to add
ImageDeliveryChannelsto images based on the media type