Validate AV policyData in API #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…policy values from engine
Rename audio-mp3-128 transcode policy to audio-mp3-128k
griffri
force-pushed
the
feature/api_validate_av_policydata
branch
from
23abde6
to
76a78d2
Compare
donaldgray
reviewed
Mar 14, 2024
...st/API.Tests/Features/DeliveryChannels/Validation/DeliveryChannelPolicyDataValidatorTests.cs
Outdated
Show resolved
Hide resolved
src/protagonist/API/Features/DeliveryChannels/AvChannelPolicyOptionsRepository.cs
Outdated
Show resolved
Hide resolved
JackLewis-digirati
requested changes
Mar 14, 2024
...st/API.Tests/Features/DeliveryChannels/Validation/DeliveryChannelPolicyDataValidatorTests.cs
Outdated
Show resolved
Hide resolved
src/protagonist/API/Features/DeliveryChannels/AvChannelPolicyOptionsRepository.cs
Show resolved
Hide resolved
src/protagonist/API/Features/DeliveryChannels/DeliveryChannelPoliciesController.cs
Outdated
Show resolved
Hide resolved
src/protagonist/API/Features/DeliveryChannels/Validation/DeliveryChannelPolicyDataValidator.cs
Outdated
Show resolved
Hide resolved
…xception to return 500
Throw ApiException instead of returning null when JsonSerializer fails Use ``(string[])null` instead of `string[] nullAvPolicies = null;` in delivery channel tests Remove unused usings Cache null object if null is returned from Engine AV policies endpoint Add GetAllowedAvOptions_RetrievesAllowedAvPolicies test to EngineClientTests Rewrite EngineClient to only send assets to "/asset-ingest", skip legacy EngineClient tests Use ConfigureBasicAuthedIntegrationTestHttpClient overload Use `async Task` instead of `async void`
donaldgray
requested changes
Mar 15, 2024
src/protagonist/API/Features/DeliveryChannels/AvChannelPolicyOptionsRepository.cs
Outdated
Show resolved
Hide resolved
src/protagonist/API/Features/DeliveryChannels/DeliveryChannelPoliciesController.cs
Outdated
Show resolved
Hide resolved
src/protagonist/API/Features/DeliveryChannels/DeliveryChannelPoliciesController.cs
Outdated
Show resolved
Hide resolved
Turn Hydra delivery channel validation handling into method Allow Engine AV policy endpoint responses to be cached as `null` Add test that ensures that GetAllowedAvPolicyOptions() returns null if the Engine AV policy endpoint is unreachable Remove unused fields from DeliveryChannelPoliciesController Use (string[])null) for other null tests Fix incorrectly set up log call
… property Use `is not` instead of `!= typeof()` in DeliveryChannelPoliciesController
donaldgray
approved these changes
Mar 15, 2024
JackLewis-digirati
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #751 and WDC-54
This PR gives
DeliveryChannelPolicyValidatorthe ability to validate AV policyData against a cached list of transcoder policies retrieved from the new/allowed-avendpoint added to Engine in #726.It also introduces a new change to the API
appSettings.json:EngineDirectIngestUrihas now been replaced withEngineRoot-EngineClientcalls/allowed-av,/image-ingestand/asset-ingestusing this as the base URL.