Validate AV policyData in API

src/protagonist/API.Tests/Features/DeliveryChannels/Validation/DeliveryChannelPolicyDataValidatorTests.cs

@@ -1,14 +1,26 @@
-using API.Features.DeliveryChannels.Validation;
+using System.Threading.Tasks;
+using API.Features.DeliveryChannels.Validation;
+using DLCS.Model.DeliveryChannels;
+using FakeItEasy;
 
 namespace API.Tests.Features.DeliveryChannelPolicies.Validation;
 
 public class DeliveryChannelPolicyDataValidatorTests
 {
     private readonly DeliveryChannelPolicyDataValidator sut;
+    private readonly string[] fakedAvPolicies =
+    {
+        "video-mp4-480p",
+        "video-webm-720p",
+        "audio-mp3-128k"
+    };
 
     public DeliveryChannelPolicyDataValidatorTests()
     {
-        sut = new DeliveryChannelPolicyDataValidator();
+        var avChannelPolicyOptionsRepository = A.Fake<IAvChannelPolicyOptionsRepository>();
+        A.CallTo(() => avChannelPolicyOptionsRepository.RetrieveAvChannelPolicyOptions())
+            .Returns(fakedAvPolicies);
+        sut = new DeliveryChannelPolicyDataValidator(avChannelPolicyOptionsRepository);
     }
 
     [Theory]
@@ -17,36 +29,36 @@ public DeliveryChannelPolicyDataValidatorTests()
     [InlineData("[\"400,\",\"200,\",\"100,\"]")]
     [InlineData("[\"!400,\",\"!200,\",\"!100,\"]")]
     [InlineData("[\"400,400\"]")]
-    public void PolicyDataValidator_ReturnsTrue_ForValidThumbSizes(string policyData)
+    public async Task PolicyDataValidator_ReturnsTrue_ForValidThumbSizes(string policyData)
     {
         // Arrange And Act
-        var result = sut.Validate(policyData, "thumbs");
+        var result = await sut.Validate(policyData, "thumbs");
 
         // Assert
         result.Should().BeTrue();
     }
 
     [Fact]
-    public void PolicyDataValidator_ReturnsFalse_ForBadThumbSizes()
+    public async Task PolicyDataValidator_ReturnsFalse_ForBadThumbSizes()
     {
         // Arrange
         var policyData = "[\"400,400\",\"foo,bar\",\"100,100\"]";
 
         // Act
-        var result = sut.Validate(policyData, "thumbs");
+        var result = await sut.Validate(policyData, "thumbs");
 
         // Assert
         result.Should().BeFalse();
     }
 
     [Fact]
-    public void PolicyDataValidator_ReturnsFalse_ForInvalidThumbSizesJson()
+    public async Task PolicyDataValidator_ReturnsFalse_ForInvalidThumbSizesJson()
     {
         // Arrange
         var policyData = "[\"400,400\",";
 
         // Act
-        var result = sut.Validate(policyData, "thumbs");
+        var result = await sut.Validate(policyData, "thumbs");
 
         // Assert
         result.Should().BeFalse();
@@ -56,36 +68,45 @@ public void PolicyDataValidator_ReturnsFalse_ForInvalidThumbSizesJson()
     [InlineData("")]
     [InlineData("[]")]
     [InlineData("[\"\"]")]
-    public void PolicyDataValidator_ReturnsFalse_ForEmptyThumbSizes(string policyData)
+    public async Task PolicyDataValidator_ReturnsFalse_ForEmptyThumbSizes(string policyData)
     {
         // Arrange and Act
-        var result = sut.Validate(policyData, "thumbs");
+        var result = await sut.Validate(policyData, "thumbs");
 
         // Assert
         result.Should().BeFalse();
     }
 
-    [Fact]
-    public void PolicyDataValidator_ReturnsTrue_ForValidAvPolicy()
+    [Theory]
+    [InlineData("[\"video-mp4-480p\"]")]
+    [InlineData("[\"video-webm-720p\"]")]
+    [InlineData("[\"audio-mp3-128k\"]")]
+    public async Task PolicyDataValidator_ReturnsTrue_ForValidAvPolicy(string policyData)
     {
-        // Arrange
-        var policyData = "[\"media-format-quality\"]"; // For now, any single string values are accepted - this will need
-                                                       // to be rewritten once the API requires policies that exist
-
-        // Act
-        var result = sut.Validate(policyData, "iiif-av");
+        // Arrange and Act
+        var result = await sut.Validate(policyData, "iiif-av");
 
         // Assert
         result.Should().BeTrue();
     }
 
+    [Fact]
+    public async Task PolicyDataValidator_ReturnsFalse_ForNonexistentAvPolicy()
+    {
+        // Arrange and Act
+        var result = await sut.Validate("not-a-transcode-policy", "iiif-av");
+
+        // Assert
+        result.Should().BeFalse();
+    }
+
     [Theory]
     [InlineData("[\"\"]")]
     [InlineData("[\"policy-1\",\"\"]")]
-    public void PolicyDataValidator_ReturnsFalse_ForBadAvPolicy(string policyData)
+    public async Task PolicyDataValidator_ReturnsFalse_ForBadAvPolicy(string policyData)
     {
         // Arrange and Act
-        var result = sut.Validate(policyData, "iiif-av");
+        var result = await sut.Validate(policyData, "iiif-av");
 
         // Assert
         result.Should().BeFalse();
@@ -95,23 +116,23 @@ public void PolicyDataValidator_ReturnsFalse_ForBadAvPolicy(string policyData)
     [InlineData("")]
     [InlineData("[]")]
     [InlineData("[\"\"]")]
-    public void PolicyDataValidator_ReturnsFalse_ForEmptyAvPolicy(string policyData)
+    public async Task PolicyDataValidator_ReturnsFalse_ForEmptyAvPolicy(string policyData)
     {
         // Arrange and Act
-        var result = sut.Validate(policyData, "iiif-av");
+        var result = await sut.Validate(policyData, "iiif-av");
 
         // Assert
         result.Should().BeFalse();
     }
 
     [Fact]
-    public void PolicyDataValidator_ReturnsFalse_ForInvalidAvPolicyJson()
+    public async Task PolicyDataValidator_ReturnsFalse_ForInvalidAvPolicyJson()
     {
         // Arrange
         var policyData = "[\"policy-1\",";
 
         // Act
-        var result = sut.Validate(policyData, "iiif-av");
+        var result = await sut.Validate(policyData, "iiif-av");
 
         // Assert
         result.Should().BeFalse();

src/protagonist/API.Tests/Features/DeliveryChannels/Validation/HydraDeliveryChannelPolicyValidatorTests.cs

@@ -1,17 +1,30 @@
 using System;
 using API.Features.DeliveryChannels.Validation;
 using DLCS.HydraModel;
+using DLCS.Model.Assets;
+using DLCS.Model.DeliveryChannels;
+using FakeItEasy;
 using FluentValidation.TestHelper;
 
 namespace API.Tests.Features.DeliveryChannelPolicies.Validation;
 
 public class HydraDeliveryChannelPolicyValidatorTests
 {
     private readonly HydraDeliveryChannelPolicyValidator sut;
+    private readonly string[] fakedAvPolicies =
+    {
+        "video-mp4-480p",
+        "video-webm-720p",
+        "audio-mp3-128k"
+    };
 
     public HydraDeliveryChannelPolicyValidatorTests()
     {
-        sut = new HydraDeliveryChannelPolicyValidator(new DeliveryChannelPolicyDataValidator());
+        var avChannelPolicyOptionsRepository = A.Fake<IAvChannelPolicyOptionsRepository>();
+        A.CallTo(() => avChannelPolicyOptionsRepository.RetrieveAvChannelPolicyOptions())
+            .Returns(fakedAvPolicies);
+        sut = new HydraDeliveryChannelPolicyValidator(
+            new DeliveryChannelPolicyDataValidator(avChannelPolicyOptionsRepository));
     }
 
     [Fact]
@@ -90,4 +103,16 @@ public void NewDeliveryChannelPolicy_Requires_PolicyData_OnPut()
         var result = sut.TestValidate(policy, p => p.IncludeRuleSets("default", "put"));
         result.ShouldHaveValidationErrorFor(p => p.PolicyData);
     }
+
+    [Fact]
+    public async void NewDeliveryChannelPolicy_Requires_ValidTranscodePolicy_ForAvChannel()
+    {
+        var policy = new DeliveryChannelPolicy()
+        {
+            Channel = AssetDeliveryChannels.Timebased,
+            PolicyData = "[\"not-a-transcode-policy\"]"
+        };
+        var result = await sut.TestValidateAsync(policy);
+        result.ShouldHaveValidationErrorFor(p => p.PolicyData);
+    }
 }