Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent new assets from receiving invalid default delivery channels #792

Merged
merged 5 commits into from
Apr 11, 2024

Conversation

griffri
Copy link
Contributor

@griffri griffri commented Apr 10, 2024

Resolves #788

This PR prevents new assets from being created if the default delivery channels matched to them are invalid - i.e, contain none alongside real channel types.

@griffri griffri marked this pull request as ready for review April 10, 2024 12:14
@griffri griffri requested a review from a team as a code owner April 10, 2024 12:14
@griffri griffri marked this pull request as draft April 10, 2024 12:15
…ToCreateAsset_WhenMatchingDefaultDeliveryChannelsAreInvalid
@griffri griffri marked this pull request as ready for review April 10, 2024 12:43
@griffri griffri merged commit bf516aa into develop Apr 11, 2024
9 checks passed
@griffri griffri deleted the fix/default_delivery_channel_fixes branch April 11, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default Delivery Channels shouldn't be able to create assets with channels of none + other policies
3 participants