Remove storage and use of low.jpg #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the need to read low.jpg when creating thumbs
donaldgray
force-pushed
the
feature/remove_lowjpg
branch
from
0ba324e
to
1ad8def
Compare
JackLewis-digirati
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #813 (WDC-81)
This PR updates engine to no longer store
low.jpg(a copy of the largest thumb regardless of accessibility). Instead we only store 1 single copy of each thumbnail and calculate the size when requested. This affects:Refactored logic from
IIIFCanvasFactoryto introduceSizeClosestTo- this takes available sizes and target size.Refactored thumb calculation logic from
IIIFCanvasFactory, introduced in #810, intoMetadataWithFallbackThumbSizeProvider : IThumbSizeProvider. This logic will:AssetApplicationMetadata. If found, return sizes. Else,Also added a couple of helpers to make writing tests easier