Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update main with bugfixes from develop #857

Merged
merged 19 commits into from
May 28, 2024
Merged

Update main with bugfixes from develop #857

merged 19 commits into from
May 28, 2024

Conversation

donaldgray
Copy link
Member

main and develop got out of sync as former container bugfixes for delivery-channels, for release 1.3.1

griffri and others added 19 commits May 9, 2024 11:04
@griffri
Update DeliveryChannelPolicyDataValidator rules to disallow '!w,' and…
8c91d9f 
… '!,h' thumbnails
@griffri
Refactor IsValidThumbnailParameter pattern matching
57148b8
@griffri
Return 404 on retrieving a single asset manifest if image delivery ch…
dfcc225 
…annels are unavailable
@griffri
Exclude painting annotation body if image service unavailable
136cff0
@griffri
Merge pull request #844 from dlcs/fix/disallow_policy_thumbparameters
1611cf6 
Reject `!w,` `!,h` IIIF parameters in Thumbs channel `policyData`
@griffri
Add .WithTestDeliveryChannel() helper
bbcacf9
@griffri
Add HasAnyDeliveryChannel helper to AssetDeliveryChannels
a602a45
@griffri
Update GetManifestForAsset to return 404 if asset is null, use HasAny…
7aab5bf 
…DeliveryChannel

Exclude asset image resources for V2 manifest if image service unavailable

Update manifest tests
@griffri
Add HasAnyDeliveryChannel tests
937e97f
@griffri
Add image delivery channel to asset in Get_V3ManifestForImage_Returns…
a915005 
…ManifestNoThumbnails_WhenNoThumbsChannel
@griffri
Update manifest handling tests
8a2be53
@griffri
Refactor HasAnyDeliveryChannel()
6f60a04 
Allow WithTestDeliveryChannel() to create IDCs with unknown channels - add more information in policy match exception message

Remove using NuGet.Packaging - not used
@griffri
Use HasAnyDeliveryChannel() to determine if an asset has a specific d…
07101bd 
…elivery channel in HasDeliveryChannel
@griffri
Merge pull request #837 from dlcs/fix/manifest_shows_correct_services
8eb4fc1 
Remove image services from asset manifest if not available
@griffri
Use a unique directory for working files when ingesting an image
89c2046
@griffri
Set IngestionContext IngestId on creation
1bde5b4 
Set ScratchRoot for ImageIngesterWorkerTests and ImageIngestPostProcessingTests
@griffri
Separate customerId from ingestId in source folder path
2857974 
Delete top level working folder after ingest
@griffri
Handle backslash directory separators in image ingestion tests
ba6ec61 
Rewrite GetSourceFolder to take IngestionContext instead of separate ingest/asset IDs
@griffri
Merge pull request #851 from dlcs/fix/concurrent_ingest
2e52754 
Use unique directory names for `ImageServerClient` output images
@donaldgray donaldgray requested a review from a team as a code owner May 28, 2024 08:41
@donaldgray donaldgray merged commit d128462 into main May 28, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@griffri griffri griffri approved these changes

@JackLewis-digirati JackLewis-digirati JackLewis-digirati approved these changes

@tomcrane tomcrane Awaiting requested review from tomcrane tomcrane is a code owner automatically assigned from dlcs/dlcs-developers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@donaldgray @griffri @JackLewis-digirati