Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update main with bugfixes from develop #857

Merged
merged 19 commits into from
May 28, 2024
Merged

Update main with bugfixes from develop #857

merged 19 commits into from
May 28, 2024

Commits on May 9, 2024

  1. Update DeliveryChannelPolicyDataValidator rules to disallow '!w,' and… 

    … '!,h' thumbnails
    @griffri
    griffri committed May 9, 2024
    Configuration menu
    Copy the full SHA
    8c91d9f View commit details
    Browse the repository at this point in the history

  2. Refactor IsValidThumbnailParameter pattern matching

    @griffri
    griffri committed May 9, 2024
    Configuration menu
    Copy the full SHA
    57148b8 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Return 404 on retrieving a single asset manifest if image delivery ch… 

    …annels are unavailable
    @griffri
    griffri committed May 10, 2024
    Configuration menu
    Copy the full SHA
    dfcc225 View commit details
    Browse the repository at this point in the history

  2. Exclude painting annotation body if image service unavailable

    @griffri
    griffri committed May 10, 2024
    Configuration menu
    Copy the full SHA
    136cff0 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #844 from dlcs/fix/disallow_policy_thumbparameters 

    Reject `!w,` `!,h` IIIF parameters in Thumbs channel `policyData`
    @griffri
    griffri committed May 10, 2024
    Configuration menu
    Copy the full SHA
    1611cf6 View commit details
    Browse the repository at this point in the history

  4. Add .WithTestDeliveryChannel() helper

    @griffri
    griffri committed May 10, 2024
    Configuration menu
    Copy the full SHA
    bbcacf9 View commit details
    Browse the repository at this point in the history

  5. Add HasAnyDeliveryChannel helper to AssetDeliveryChannels

    @griffri
    griffri committed May 10, 2024
    Configuration menu
    Copy the full SHA
    a602a45 View commit details
    Browse the repository at this point in the history

  6. Update GetManifestForAsset to return 404 if asset is null, use HasAny… 

    …DeliveryChannel

Exclude asset image resources for V2 manifest if image service unavailable

Update manifest tests
    @griffri
    griffri committed May 10, 2024
    Configuration menu
    Copy the full SHA
    7aab5bf View commit details
    Browse the repository at this point in the history

  7. Add HasAnyDeliveryChannel tests

    @griffri
    griffri committed May 10, 2024
    Configuration menu
    Copy the full SHA
    937e97f View commit details
    Browse the repository at this point in the history

  8. Add image delivery channel to asset in Get_V3ManifestForImage_Returns… 

    …ManifestNoThumbnails_WhenNoThumbsChannel
    @griffri
    griffri committed May 10, 2024
    Configuration menu
    Copy the full SHA
    a915005 View commit details
    Browse the repository at this point in the history

  9. Update manifest handling tests

    @griffri
    griffri committed May 10, 2024
    Configuration menu
    Copy the full SHA
    8a2be53 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Refactor HasAnyDeliveryChannel() 

    Allow WithTestDeliveryChannel() to create IDCs with unknown channels - add more information in policy match exception message

Remove using NuGet.Packaging - not used
    @griffri
    griffri committed May 20, 2024
    Configuration menu
    Copy the full SHA
    6f60a04 View commit details
    Browse the repository at this point in the history

  2. Use HasAnyDeliveryChannel() to determine if an asset has a specific d… 

    …elivery channel in HasDeliveryChannel
    @griffri
    griffri committed May 20, 2024
    Configuration menu
    Copy the full SHA
    07101bd View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Merge pull request #837 from dlcs/fix/manifest_shows_correct_services 

    Remove image services from asset manifest if not available
    @griffri
    griffri committed May 21, 2024
    Configuration menu
    Copy the full SHA
    8eb4fc1 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Use a unique directory for working files when ingesting an image

    @griffri
    griffri committed May 22, 2024
    Configuration menu
    Copy the full SHA
    89c2046 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. Set IngestionContext IngestId on creation 

    Set ScratchRoot for ImageIngesterWorkerTests and ImageIngestPostProcessingTests
    @griffri
    griffri committed May 23, 2024
    Configuration menu
    Copy the full SHA
    1bde5b4 View commit details
    Browse the repository at this point in the history

  2. Separate customerId from ingestId in source folder path 

    Delete top level working folder after ingest
    @griffri
    griffri committed May 23, 2024
    Configuration menu
    Copy the full SHA
    2857974 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. Handle backslash directory separators in image ingestion tests 

    Rewrite GetSourceFolder to take IngestionContext instead of separate ingest/asset IDs
    @griffri
    griffri committed May 24, 2024
    Configuration menu
    Copy the full SHA
    ba6ec61 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. Merge pull request #851 from dlcs/fix/concurrent_ingest 

    Use unique directory names for `ImageServerClient` output images
    @griffri
    griffri committed May 28, 2024
    Configuration menu
    Copy the full SHA
    2e52754 View commit details
    Browse the repository at this point in the history