-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ImageOptimisationPolicy
and ThumbnailPolicy
support to LegacyModeConverter
#860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7af5188
to
f81432b
Compare
…lProperties is enabled, add tests
…annel property emulation enabled Add test method for creating delivery channel policies for a user
…f legacy is enabled
Clean up DB when setting up CustomerQueueWithOldDeliveryChannelPropertiesTests
Merge `WithOldDeliveryChannelProperties` tests with main test files
… in legacy payloads
7e52113
to
f1873fc
Compare
JackLewis-digirati
approved these changes
Jun 4, 2024
Use BadRequestException, better handling of mediaTypes and allow tp and iop to be provided without the value
donaldgray
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #784 and WDC-68
This PR updates
LegacyModeConverter
so that it can translate common DeliveratorImageOptimisationPolicy
andThumbnailPolicy
settings into their delivery channel counterparts.Origin
is now required when creating or updating assets when legacy mode is enabled.