-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getting stuck after "sign_and_send_pubkey" #387
Comments
KeeAgent version? Agent mode or Client mode? |
KeeAgent v0.13.5.0 agent mode. |
I've the same issue but only with an old RSA key. I never have problems with my ED25519 keys. Sometimes the RSA key works, sometimes not. I could not find any regularity. Only happens in Windows OpenSSH. With PuTTY it works without any issue. One difference between my ED25519 and the RSA key: I had "Use confirm constraint" enabled for the RSA key. Disabled it now. I will watch it. |
Today I've seen this behavior also with an ED25519 key. But also a key with "Use confirm constraint" enabled. I disabled it and restartet KeePass to have a "clean state". Afterwards it worked. Still will watch it. |
This sounds like something is blocking the main UI thread in KeePass preventing the confirmation dialog from being shown. Do you have any other extensions installed? |
Yes (all in latest version):
|
Does keeagent still lock up if you disable all other extensions? |
I've to test it over some more days because the problem does not appear every time. |
Hm, unfortunately I'm able reproduce the problem with all other plugins disabled. |
I can confirm that I can reproduce the same kind issue when I activate the global config "Always require user confirmation when a client program requests to use a key" : when I try to connect to a host with windows openssh (OpenSSH_for_Windows_8.6p1) the confirmation pop up never appears and connection gets stuck. Interestingly the pop-up appears correctly and everything works fine when I connect with putty. When I deactivate the user confirmation and just use "Show a notification when a key is used", I can successfully connect both with putty and windows openssh. I have Keepass v2.52 and KeeAgent 0.13.5.0 on windows 11. Unfortunately I don't have the required setup at hand to generate a debug trace. |
It'd be great if anyone with stable reproducibility of the issue could try the plugin version from PR #394 |
I did a quick test:
I wouldn't say it's 100 percent, but it looks good. |
I can confirm the same. For the last 3 month I used my own custom built plugin and had no single issue with it getting stuck. @elieux , I attached to the PR #394 KeeAgent_v0.13.6-fix387.zip that is based on another approach. I'll appreciate if you test it as well. |
* probable fix for #387 - getting stuck on key usage confirmation * Separate UI thread dedicated for the KeeAgent Plugin UI interactions
Confirming that this one also immediately worked. |
@elieux , FYI, you can use a fresh build from the GitHub actions while you are waiting for the next release: https://github.com/dlech/KeeAgent/actions/runs/7604354479 |
I keep having weird issues with SSH getting stuck when trying to authenticate using keys and I wonder whether KeeAgent could be at fault here.
When it starts, the issue keeps happening consistently, but it seems to get resolved later by itself. During the time I took to write this ticket for example, case 2 started working again.
At the point where the client gets stuck, I'd expect a confirmation dialog from KeeAgent, but it doesn't show up.
The relevant log snippet from case 2 right now (redacted):
The text was updated successfully, but these errors were encountered: