Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build error using windows sln file #39

Open
Chris-R-R opened this issue Dec 2, 2022 · 3 comments
Open

Build error using windows sln file #39

Chris-R-R opened this issue Dec 2, 2022 · 3 comments
Assignees

Comments

@Chris-R-R
Copy link

error C2065: 'DUPLO_VERSION': undeclared identifier

@Chris-R-R
Copy link
Author

I defined that macro and then got another error:

1>FileTypeFactory.obj : error LNK2019: unresolved external symbol "public: __thiscall FileType_Ada::FileType_Ada(bool,unsigned int)" (??0FileType_Ada@@QAE@_NI@Z) referenced in function "class std::shared_ptr __cdecl FileTypeFactory::CreateFileType(class std::basic_string<char,struct std::char_traits,class std::allocator > const &,bool,unsigned int)" (?CreateFileType@FileTypeFactory@@ya?AV?$shared_ptr@UIFileType@@@std@@abv?$basic_string@DU?$char_traits@D@std@@v?$allocator@D@2@@3@_NI@Z)
1>Debug\Duplo.exe : fatal error LNK1120: 1 unresolved externals

I am building from the sln file in the downloaded zip

@Chris-R-R
Copy link
Author

I don't care about Ada support so I commented out lines 27 and 28 in FileTypeFactory.cpp and then it was able to build.

@dlidstrom
Copy link
Owner

Yeah I don't keep the solution and vcxproj files updated. You can just add the missing file to the project file then it will compile (presumably, since there's nothing special about Ada support, see it's missing here).
If you do then you could add a PR for both fixes and become a contributor. Thanks!

@dlidstrom dlidstrom assigned dlidstrom and Chris-R-R and unassigned dlidstrom Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants