time.clock is deprecated - python 3.7

[ErwinHaasnoot]

When using RSA encrypt with PKCS1_AOEP padding, DeprecationWarnings are thrown.

Prerequisites: an RSA private key in mykey.pem

openssl genrsa -out mykey.pem 1024

Run the following with the "-W error" option to trigger the warning and print stacktrace:

import os
from Crypto.PublicKey import RSA
from Crypto.Cipher import PKCS1_OAEP
from Crypto.Hash import SHA
with open('rsa.key') as f: key = f.read()
rsa_key = RSA.importKey(key)
rsa = PKCS1_OAEP.new(rsa_key, SHA)
encdata = rsa.encrypt(data)

Traceback (most recent call last):
  File "test.py", line 13, in <module>
    encdata = rsa.encrypt(data)
  File "/usr/local/lib/python3.7/site-packages/Crypto/Cipher/PKCS1_OAEP.py", line 152, in encrypt
    ros = randFunc(hLen)
  File "/usr/local/lib/python3.7/site-packages/Crypto/Random/_UserFriendlyRNG.py", line 202, in read
    return self._singleton.read(bytes)
  File "/usr/local/lib/python3.7/site-packages/Crypto/Random/_UserFriendlyRNG.py", line 178, in read
    return _UserFriendlyRNG.read(self, bytes)
  File "/usr/local/lib/python3.7/site-packages/Crypto/Random/_UserFriendlyRNG.py", line 129, in read
    self._ec.collect()
  File "/usr/local/lib/python3.7/site-packages/Crypto/Random/_UserFriendlyRNG.py", line 77, in collect
    t = time.clock()
DeprecationWarning: time.clock has been deprecated in Python 3.3 and will be removed from Python 3.8: use time.perf_counter or time.process_time instead```

[tirkarthi]

time.clock is now removed in 3.8 : python/cpython#13270

[rhanka]

python 3.8 is now the official 3 for docker images

This problem has then to be solved for most people who will use python 3 with docker.

We have the problem, as we use a docker container for encrypting fake data in our travis process (https://github.com/histovec/histovec-beta/). Even if the resource is not critical for our project, is would seem hygienic to solve this

...
    iv = Random.new.read(AES.bloc_ksize)
  File "/usr/local/lib/python3.7/site-packages/Crypto/Random/_UserFriendlyRNG.py", line 202, in read
    return self._singleton.read(bytes)
  File "/usr/local/lib/python3.7/site-packages/Crypto/Random/_UserFriendlyRNG.py", line 178, in read
    return _UserFriendlyRNG.read(self, bytes)
  File "/usr/local/lib/python3.7/site-packages/Crypto/Random/_UserFriendlyRNG.py", line 129, in read
    self._ec.collect()
  File "/usr/local/lib/python3.7/site-packages/Crypto/Random/_UserFriendlyRNG.py", line 77, in collect
    t = time.clock()
DeprecationWarning: time.clock has been deprecated in Python 3.3 and will be removed from Python 3.8: use time.perf_counter or time.process_time instead

Users of the Crytpo lib with docker must now downgrade using a FROM python:3.7-slim (or FROM python:3.7) instead of FROM python:3-slim (or FROM python:3) in their Dockerfile, at least until the problem has been fixed and close here.

[ErwinHaasnoot]

Thanks. Please note that this library has been deprecated and one should switch to pycryptodome for an API-compatible, updated lib, or to cryptography.io for a more modern API.

…

On Thu, Jan 9, 2020, 2:05 PM Fabien Antoine ***@***.***> wrote: python 3.8 is now the official 3 for docker images This problem has then to be solved for most people who will use python 3 with docker. We have the problem, as we use a docker container for encrypting fake data in our travis process (https://github.com/histovec/histovec-beta/). Even if the resource is not critical for our project, is would seem hygienic to solve this ... iv = Random.new.read(AES.bloc_ksize) File "/usr/local/lib/python3.7/site-packages/Crypto/Random/_UserFriendlyRNG.py", line 202, in read return self._singleton.read(bytes) File "/usr/local/lib/python3.7/site-packages/Crypto/Random/_UserFriendlyRNG.py", line 178, in read return _UserFriendlyRNG.read(self, bytes) File "/usr/local/lib/python3.7/site-packages/Crypto/Random/_UserFriendlyRNG.py", line 129, in read self._ec.collect() File "/usr/local/lib/python3.7/site-packages/Crypto/Random/_UserFriendlyRNG.py", line 77, in collect t = time.clock() DeprecationWarning: time.clock has been deprecated in Python 3.3 and will be removed from Python 3.8: use time.perf_counter or time.process_time instead Users of the Crytpo lib with docker must now downgrade using a FROM python:3.7-slim (or FROM python:3.7) instead of FROM python:3-slim (or FROM python:3) in their Dockerfile, at least until the problem has been fixed and close here. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#283>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKTFVIWKFCK5M4CY4P64GDQ44OJVANCNFSM4GS7HDWA> .

[rhanka]

Thank your for your response - this explanation is profitable !

[cs01]

@ErwinHaasnoot if this library is deprecated, could it be marked as such on PyPI, GitHub and other relevant pages? It is not clear when stumbling across the project from search results. I luckily found it when running into this Python 3.8 incompatibility.

[ErwinHaasnoot]

That would be great. Unfortunately I don't have commit rights; maybe a merge request would be accepted if sent.

…

On Sat, Feb 8, 2020, 2:37 AM Chad Smith ***@***.***> wrote: @ErwinHaasnoot <https://github.com/ErwinHaasnoot> if this library is deprecated, could it be marked as such on PyPI, GitHub and other relevant pages? It is not clear when stumbling across the project from search results. I luckily found it when running into this Python 3.8 incompatibility. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#283>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKTFVKXCR6VMTAKBCZ23YDRBYEFPANCNFSM4GS7HDWA> .

[ThanhTuNguyen]

Please fix this bug, downgrade to 3.7 is not the acceptable solution

[SwapnilSoni1999]

2020 and still no fixed yet

[michael-k]

@SwapnilSoni1999 see above:

Please note that this library has been deprecated and one should
switch to pycryptodome for an API-compatible, updated lib, or to
cryptography.io for a more modern API.

[SwapnilSoni1999]

Okay thanks tho <3
I would suggest to archive or add deprecated tag/text on title description

[cs01]

Good idea #283 (comment)

[whitespots]

+1 to waiters

[dingyaguang117]

Please try this polyfill

time.clock = time.process_time

[cccnrc]

+1 to waiters

[AyliD]

+1 for waiter

[Pitastic]

+1 for waiter

[cygnusb]

+1

[jfunction]

waiter++

[jfunction]

waiter--
I switched to pycryptodome and that worked for me.