Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prosEO CLI] Null user and commands which require login #28

Closed
dlr-tangosierra opened this issue Feb 27, 2020 · 1 comment
Closed

[prosEO CLI] Null user and commands which require login #28

dlr-tangosierra opened this issue Feb 27, 2020 · 1 comment
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed

Comments

@dlr-tangosierra
Copy link
Contributor

dlr-tangosierra commented Feb 27, 2020

Testing parameters:
User Login: no user login
Mission : no mission

Context:
When the user tries a command which requires login, [mission show] in this case, the error messages show that the user is not logged in which is a normal output message but as a second message the system shows to the user that it tries to revert to a null user for privileges. From the system design point of view, this could be a security concern, in case by mistake the null user gains such privileges. The nature of this error message causes confusion as well and is a security concern by itself.

Example output:
prosEO> mission show
(E2802) User not logged in
(E2803) User null not authorized to manage missions for mission null

Examples with other commands:
example for the command [product show]
prosEO> product show abc
(E2802) User not logged in
(E2803) User null not authorized to manage products for mission null

example for the command [productclass show]
prosEO> productclass show
(E2802) User not logged in
(E2803) User null not authorized to manage product classes for mission null

example for the command [productclass delete]
prosEO> productclass delete abc
(E2802) User not logged in
(E2803) User null not authorized to manage product classes for mission null

example for the command [productclass update]
prosEO> productclass update abc
(E2802) User not logged in
(E2803) User null not authorized to manage product classes for mission null

Similar issues occur with the commands [orbit], [order] and [configuration]

@dlr-tangosierra dlr-tangosierra changed the title [prosEO CLI] Null user [prosEO CLI] Null user and commands which require login Feb 27, 2020
@dlr-tangosierra dlr-tangosierra added bug Something isn't working enhancement New feature or request help wanted Extra attention is needed labels Feb 27, 2020
@tangobravo62
Copy link
Collaborator

Fixed. "mission show" is allowed without login, and all other commands require prior login:

prosEO> mission show
---
- id: 59
  version: 1
  code: "ABC"
  name: null
  fileClasses:
  - "OPER"
  processingModes:
  - "OFFL"
  productFileTemplate: null
  spacecrafts:
[...]

prosEO> product show abc
(E2802) User not logged in
prosEO> productclass show
(E2802) User not logged in
prosEO> productclass delete abc
(E2802) User not logged in
prosEO> productclass update abc
(E2802) User not logged in
prosEO> 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants