Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove owc-control #77

Closed
MichaelLangbein opened this issue Mar 25, 2021 · 1 comment · Fixed by #102
Closed

Remove owc-control #77

MichaelLangbein opened this issue Mar 25, 2021 · 1 comment · Fixed by #102
Labels
enhancement feat: (New feature or request)

Comments

@MichaelLangbein
Copy link
Collaborator

Description

The project dlr-eoc/owc-control does not add much useful anymore.
As discussed here, it used to be useful because it added a download-functionality in combination with saving current state as OWC-Json, but that download functionality is now also available in @dlr-eoc/utils-browser.

As such, this project can be removed.

  • Does this change impact existing behaviors? If so how?
    • No, the project has not been used anywhere else in the frontend-libraries, and neither has it been used in any other projects derived from FELibs as far as I could find.

Relevant Package

This feature request is for @dlr-eoc/owc-control

@MichaelLangbein MichaelLangbein added the enhancement feat: (New feature or request) label Mar 25, 2021
@boeckMt
Copy link
Member

boeckMt commented May 6, 2021

Looks like the Package is used in https://github.com/dlr-eoc/ukis-frontend-libraries/blob/v7.3.1/projects/demo-maps/src/app/route-components/route-example-layers/route-map.component.html#L54

So if we remove it we should adjust the demo to reimplement the component https://github.com/dlr-eoc/ukis-frontend-libraries/blob/v7.3.1/projects/owc-control/src/lib/owc-control.component.ts

Maybe we can also add the logic of the component to a function in some utils

import { combineLatest } from 'rxjs';
import { first, map } from 'rxjs/operators';
...

 getState(layerSvc: LayersService, mapStateSvc: MapStateService) {
    const blSub = layerSvc.getBaseLayers();
    const olSub = layerSvc.getOverlays();
    const llSub = layerSvc.getLayers();
    const exSub = mapStateSvc.getExtent();
    const stSub = mapStateSvc.getMapState();
    const all = [blSub, olSub, llSub, exSub, stSub];
    return combineLatest(all).pipe(map((res) => {
      return {
        BaseLayers: res[0] as Layer[],
        Overlays: res[1] as Layer[],
        Layers: res[2] as Layer[],
        Extent: res[3] as TGeoExtent,
        MapState: res[4] as MapState,
      };
    }));
}

const id = 'myContext';
this.getState(this.layerSvc, this.mapStateSvc).pipe(first()).subscribe(data => {
    const owc = this.owcSvc.generateOwsContextFrom(id, [...data.BaseLayers, ...data.Overlays, ...data.Layers], data.Extent);
    this.downloadFile(owc, `${id}.json`);
});

@boeckMt boeckMt mentioned this issue Nov 23, 2021
14 tasks
@boeckMt boeckMt closed this as completed Nov 24, 2021
boeckMt added a commit that referenced this issue Dec 9, 2021
* v8.0.0-next.1

* build: fix package version that doesn't exist

* fix wrong dependency

* feat: legend image open as link

* BREAKING CHANGE: adjust eoc-owc-json types to the new schema

* feat: add new schema which extends owc-ogc.schema.json and sync types with them

* fix: add missing output for progress

* feat: export Layertype tms and refactor TLayertype

* fix: typo in core profile

* test: add sample data to test owc service #97

* BREAKING CHANGE: elevation dimension display as object like for time dimensions

* BREAKING CHANGE: elevation dimension display as object like for time dimensions

* feat: export new layer types for tms and kml

* BREAKING CHANGE: isVectorLayertype and isRasterLayertype can both be raster and vector

* docs: isVectorLayertype and isRasterLayertype can both be raster and vector

* docs: add descriptions for owc types

* docs: fix: add missing output for progress

* refactor: remove duplicate display

* docs: for matrixSet of wmts properties

* feat: export different interfaces for time and elevation dimension

* docs: export different interfaces for time and elevation dimension

* feat: export const for GetCapabilities code

* refactor: use constants for often used strings

* fix: geojson layer from url

* feat: support kml vector layer

* feat: Support VetrorTile Layers as tms

* BREAKING CHANGE: replace createTmsLayerFromOffering with rasterTms and VectorTile

* feat: New Functions to get Properties from context and Resource

* refactor: getTimeValueFromDimensions - optional period

* refactor: parseSingleTimeOrPeriod - use utc

* feat: getTimeDimensions - use optional period from display if not in values

* feat: basic Implementation of getElevationDimension

* feat: Support new Layer Types KML, Xyz and Tms

* BREAKING CHANGE: remove getOfferingContents

* BREAKING CHANGE: remove custom iconUrl from offering

* fix: Preserve order of Layers and Groups from Context

* feat: getResourceDimensions - use getElevationDimension

* refactor: implement createVectorLayerFromOffering like createRaster

* refactor: implement getVectorLayerOptions like getRasterLayerOptions

* refactor: create wfs layer and fix: get params from url with searchParams

* refactor: create vector layers for data offerings

* refactor: fix get WMTS params with searchParams

* refactor: get Params from url and return UpperCase searchParams to fix: wfs, wmts, wms... getParams

* fix: do not use bbox of context for baselayers

* refactor: use searchParams in getWmsOptions

* refactor: createVectorLayerFromOffering to check for is isRasterLayertype or isVectorLayertype TMS

* refactor: parseOperationUrl to use searchParams

* refactor: get matrix set for wmts and skip if null

* refactor: add missing imports

* refactor: get props from resource and check for existence

* refactor: check for existence and return null observable

* refactor: getRasterLayerOptions

* test: add tests and data for new functions and refactoring

* refactor: replace custom extension to get title from resource

* refactor: remove not used private functions

* feat: export more operation types for owc

* fix: generate owc context with mandatory properties

* feat: use more properties from layer to generate IEocOwsResource

* feat: use more properties from layer to generate IEocOwsResource

* feat: use more properties from layer to generate IEocOwsOffering

* feat: support kml offering from layer

* feat: support basic TMS Raster and Vector offering from layer

* feat: support TMS Raster from Layer

* fix: xyz operation type from Layer

* refactor: wfs operation from Layer use searchParams

* feat: support basic TMS Vector Operation from layer

* fix: WMS Operation from layer - format and url

* fix: WMTS Operation from layer - format and url

* feat: support generate basic Dimensions from layer

* docs: Better support to convert UKIS layers to OWC

* test: more tests for UKIS layers to OWC

* feat: add data and demo for owc layers

* fix: Syntax error because of not committed lines

* feat: Support Tiled- and Image-WMS Layers

* docs: add more descriptions for owc types

* build: update proposed node and npm version

* BREAKING CHANGE: remove @dlr-eoc/owc-control #77

* build: add missing dependency to demo-maps

* feat: Support merged Layers as a single Layer #99

* docs: add more documentation for types

* feat: examples for merged layers #99

* fix: get OpenMapStyle content as string or obj

* fix: get/set default style name for raster params

* feat: sort layers from layerService for OWC order

* fix: add folder name when generating resources

* fix: add subdomains to resources also for VectorLayers if possible

* feat: try to create styles and legendImg from layers for resources

* feat: also create url contents for kml and geojson on resources

* fix: create GetFeature request with params for WFS

* fix: create WMS operations with params for resources

* fix: create WMTS operations with params for resources

* fix: create WMS operations with params for resources

* feat: add optional styleSource for OpenMapStyle to VectorLayerOptions

* refactor: adjust test context for legend only styles

* refactor: export OWC in demo - use LayerGroups so we can retrieve folder names

* refactor: format file

* Test version after owc PR

* fix: check for existing style array on offering

* refactor: check for WMS and WMTS default style

* fix: set display period from time dimensions only if single interval

* refactor: log resource if dimensions values are null

* test: fix check resource folder

* fix: merge properties in generate Ows

* test: remove unused dependencies

* test: refactor tests for resource dimensions

* test: get context layers in correct order

* test: refactor generate context from layers

* test: order of created context features

* test: fix get FilterType from resource folder

* BREAKING CHANGE: replace getLayerGroup() with getResourceFolder()

* fix: correct order for get layers from resources

* fix: pipe separately and filter null

* refactor: add type for return of(null)

* test: add examples to context for matrixSets and tests with expectations

* fix: return UpperCase searchParams

* test: fix WFS UpperCase searchParams

* fix: Set cursor to default

* refactor: set link to schema for validation

* fix: catch relative url before passing to URL()

* feat: Support mergedLayers for Baselayers

* refactor: show osm layer as default

* refactor: remove layers.reverse which is already done in getLayers

* test v2 after PR #102

* docs: Getting Started closes #101

* refactor: #102 - 821317696

* refactor: #102 - 821331259

* refactor: deprecate is raster/vector #102 - 821425785

* refactor: elevation dimensions #102 - 821428228

* refactor: #102 - 821435027

* feat: Support WMS Filters #102- 821695929

* refactor: prepare for stricter typing

* refactor: mergedLayers to type StackedLayer #102 - 822555538

* fix: refactor create wms layer

* fix: refactor test stacked Layer

* Update Layers.ts (#105)

* Update Layers.ts

typo fix pupupFunktion --> pupupFunction (could be a breaking change in come apps)

* update of map-ol.service.ts

rename pupupFunktion to pupupFunction

* Update CHANGELOG.md

Renamed layer property pupupFunktion to pupupFunction

* Update CHANGELOG.md

* Update route-map.component.ts

changed pupupFunktion to pupupFunction

* Update map-ol.service.ts

fixed typo pupupFunction to popupFunction

* Update map-ol.service.ts

fixed several typos pupup to popup

* Update map-ol.service.spec.ts

changed pupupFunktion to popupFunction

* Update Layers.ts

fixed type pupup to popup

* Update route-map.component.ts

fixed type pupup to popup

* Update CHANGELOG.md

* refactor: share assets between projects #102 - 821452316

* refactor: remove set karma log level debug

* refactor: prepare for stricter typing compilerOptions.strict

Co-authored-by: Sergey Voinov <31403272+voinSR@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement feat: (New feature or request)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants