Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Layers.ts #105

Merged
merged 11 commits into from
Dec 7, 2021
Merged

Update Layers.ts #105

merged 11 commits into from
Dec 7, 2021

Conversation

voinSR
Copy link
Collaborator

@voinSR voinSR commented Dec 3, 2021 •
edited
Loading

typo fix pupupFunktion --> popupFunction (could be a breaking change in come apps)

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Is it part of one/more packages and which?

@voinSR
Update Layers.ts
52390de 
typo fix pupupFunktion --> pupupFunction (could be a breaking change in come apps)
@voinSR voinSR requested a review from boeckMt December 3, 2021 11:56
@boeckMt
Copy link
Member

boeckMt commented Dec 3, 2021

@voinSR Like you have mentioned, this typo is unfortunately a breaking change.

We also have to fix it everywhere where it is used. You can see it here https://github.com/dlr-eoc/ukis-frontend-libraries/pull/105/files and here https://github.com/dlr-eoc/ukis-frontend-libraries/search?q=pupupFunktion.

And can you also add it in the CHANGELOG.

@voinSR
update of map-ol.service.ts
f1ba590 
rename pupupFunktion to pupupFunction
@voinSR
Update CHANGELOG.md
3cc7ff5 
Renamed layer property pupupFunktion to pupupFunction
@voinSR
Update CHANGELOG.md
aa97b37
@voinSR
Update route-map.component.ts
18a1497 
changed pupupFunktion to pupupFunction
@voinSR
Update map-ol.service.ts
86ec66c 
fixed typo pupupFunction to popupFunction
@voinSR
Update map-ol.service.ts
21cef1c 
fixed several typos pupup to popup
@voinSR
Update map-ol.service.spec.ts
7dd023a 
changed pupupFunktion to popupFunction
@voinSR
Update Layers.ts
3c3f9f3 
fixed type pupup to popup
@voinSR
Update route-map.component.ts
2f81b6d 
fixed type pupup to popup
@voinSR
Copy link
Collaborator Author

voinSR commented Dec 6, 2021

i just figured out that there were two typos in one atribute pupupFunktion should be actually popupFunction

@voinSR
Copy link
Collaborator Author

voinSR commented Dec 6, 2021 •
edited
Loading

@boeckMt ok i think i changed it everywhere

boeckMt
boeckMt approved these changes Dec 7, 2021
View reviewed changes
Copy link
Member

@boeckMt boeckMt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for that fix!

@boeckMt boeckMt merged commit ad0ea71 into service-owc Dec 7, 2021
boeckMt added a commit that referenced this pull request Dec 9, 2021
@boeckMt @voinSR
Service owc (#102)
0853809 
* v8.0.0-next.1

* build: fix package version that doesn't exist

* fix wrong dependency

* feat: legend image open as link

* BREAKING CHANGE: adjust eoc-owc-json types to the new schema

* feat: add new schema which extends owc-ogc.schema.json and sync types with them

* fix: add missing output for progress

* feat: export Layertype tms and refactor TLayertype

* fix: typo in core profile

* test: add sample data to test owc service #97

* BREAKING CHANGE: elevation dimension display as object like for time dimensions

* BREAKING CHANGE: elevation dimension display as object like for time dimensions

* feat: export new layer types for tms and kml

* BREAKING CHANGE: isVectorLayertype and isRasterLayertype can both be raster and vector

* docs: isVectorLayertype and isRasterLayertype can both be raster and vector

* docs: add descriptions for owc types

* docs: fix: add missing output for progress

* refactor: remove duplicate display

* docs: for matrixSet of wmts properties

* feat: export different interfaces for time and elevation dimension

* docs: export different interfaces for time and elevation dimension

* feat: export const for GetCapabilities code

* refactor: use constants for often used strings

* fix: geojson layer from url

* feat: support kml vector layer

* feat: Support VetrorTile Layers as tms

* BREAKING CHANGE: replace createTmsLayerFromOffering with rasterTms and VectorTile

* feat: New Functions to get Properties from context and Resource

* refactor: getTimeValueFromDimensions - optional period

* refactor: parseSingleTimeOrPeriod - use utc

* feat: getTimeDimensions - use optional period from display if not in values

* feat: basic Implementation of getElevationDimension

* feat: Support new Layer Types KML, Xyz and Tms

* BREAKING CHANGE: remove getOfferingContents

* BREAKING CHANGE: remove custom iconUrl from offering

* fix: Preserve order of Layers and Groups from Context

* feat: getResourceDimensions - use getElevationDimension

* refactor: implement createVectorLayerFromOffering like createRaster

* refactor: implement getVectorLayerOptions like getRasterLayerOptions

* refactor: create wfs layer and fix: get params from url with searchParams

* refactor: create vector layers for data offerings

* refactor: fix get WMTS params with searchParams

* refactor: get Params from url and return UpperCase searchParams to fix: wfs, wmts, wms... getParams

* fix: do not use bbox of context for baselayers

* refactor: use searchParams in getWmsOptions

* refactor: createVectorLayerFromOffering to check for is isRasterLayertype or isVectorLayertype TMS

* refactor: parseOperationUrl to use searchParams

* refactor: get matrix set for wmts and skip if null

* refactor: add missing imports

* refactor: get props from resource and check for existence

* refactor: check for existence and return null observable

* refactor: getRasterLayerOptions

* test: add tests and data for new functions and refactoring

* refactor: replace custom extension to get title from resource

* refactor: remove not used private functions

* feat: export more operation types for owc

* fix: generate owc context with mandatory properties

* feat: use more properties from layer to generate IEocOwsResource

* feat: use more properties from layer to generate IEocOwsResource

* feat: use more properties from layer to generate IEocOwsOffering

* feat: support kml offering from layer

* feat: support basic TMS Raster and Vector offering from layer

* feat: support TMS Raster from Layer

* fix: xyz operation type from Layer

* refactor: wfs operation from Layer use searchParams

* feat: support basic TMS Vector Operation from layer

* fix: WMS Operation from layer - format and url

* fix: WMTS Operation from layer - format and url

* feat: support generate basic Dimensions from layer

* docs: Better support to convert UKIS layers to OWC

* test: more tests for UKIS layers to OWC

* feat: add data and demo for owc layers

* fix: Syntax error because of not committed lines

* feat: Support Tiled- and Image-WMS Layers

* docs: add more descriptions for owc types

* build: update proposed node and npm version

* BREAKING CHANGE: remove @dlr-eoc/owc-control #77

* build: add missing dependency to demo-maps

* feat: Support merged Layers as a single Layer #99

* docs: add more documentation for types

* feat: examples for merged layers #99

* fix: get OpenMapStyle content as string or obj

* fix: get/set default style name for raster params

* feat: sort layers from layerService for OWC order

* fix: add folder name when generating resources

* fix: add subdomains to resources also for VectorLayers if possible

* feat: try to create styles and legendImg from layers for resources

* feat: also create url contents for kml and geojson on resources

* fix: create GetFeature request with params for WFS

* fix: create WMS operations with params for resources

* fix: create WMTS operations with params for resources

* fix: create WMS operations with params for resources

* feat: add optional styleSource for OpenMapStyle to VectorLayerOptions

* refactor: adjust test context for legend only styles

* refactor: export OWC in demo - use LayerGroups so we can retrieve folder names

* refactor: format file

* Test version after owc PR

* fix: check for existing style array on offering

* refactor: check for WMS and WMTS default style

* fix: set display period from time dimensions only if single interval

* refactor: log resource if dimensions values are null

* test: fix check resource folder

* fix: merge properties in generate Ows

* test: remove unused dependencies

* test: refactor tests for resource dimensions

* test: get context layers in correct order

* test: refactor generate context from layers

* test: order of created context features

* test: fix get FilterType from resource folder

* BREAKING CHANGE: replace getLayerGroup() with getResourceFolder()

* fix: correct order for get layers from resources

* fix: pipe separately and filter null

* refactor: add type for return of(null)

* test: add examples to context for matrixSets and tests with expectations

* fix: return UpperCase searchParams

* test: fix WFS UpperCase searchParams

* fix: Set cursor to default

* refactor: set link to schema for validation

* fix: catch relative url before passing to URL()

* feat: Support mergedLayers for Baselayers

* refactor: show osm layer as default

* refactor: remove layers.reverse which is already done in getLayers

* test v2 after PR #102

* docs: Getting Started closes #101

* refactor: #102 - 821317696

* refactor: #102 - 821331259

* refactor: deprecate is raster/vector #102 - 821425785

* refactor: elevation dimensions #102 - 821428228

* refactor: #102 - 821435027

* feat: Support WMS Filters #102- 821695929

* refactor: prepare for stricter typing

* refactor: mergedLayers to type StackedLayer #102 - 822555538

* fix: refactor create wms layer

* fix: refactor test stacked Layer

* Update Layers.ts (#105)

* Update Layers.ts

typo fix pupupFunktion --> pupupFunction (could be a breaking change in come apps)

* update of map-ol.service.ts

rename pupupFunktion to pupupFunction

* Update CHANGELOG.md

Renamed layer property pupupFunktion to pupupFunction

* Update CHANGELOG.md

* Update route-map.component.ts

changed pupupFunktion to pupupFunction

* Update map-ol.service.ts

fixed typo pupupFunction to popupFunction

* Update map-ol.service.ts

fixed several typos pupup to popup

* Update map-ol.service.spec.ts

changed pupupFunktion to popupFunction

* Update Layers.ts

fixed type pupup to popup

* Update route-map.component.ts

fixed type pupup to popup

* Update CHANGELOG.md

* refactor: share assets between projects #102 - 821452316

* refactor: remove set karma log level debug

* refactor: prepare for stricter typing compilerOptions.strict

Co-authored-by: Sergey Voinov <31403272+voinSR@users.noreply.github.com>
@boeckMt boeckMt deleted the voinSR-patch-1 branch December 9, 2021 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boeckMt boeckMt boeckMt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@voinSR @boeckMt