Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aa.rest.AaRestClient.resume_archiging_pv #61

Merged
merged 2 commits into from
Sep 18, 2020
Merged

Conversation

aawdls
Copy link
Contributor

@aawdls aawdls commented Sep 18, 2020

No description provided.

@aawdls
Copy link
Contributor Author

aawdls commented Sep 18, 2020

The linting checks have failed but seemingly not because of my changes

@willrogers
Copy link
Collaborator

It appears that pylint added a rule raise-missing-from in 2.6.0 that is now failing. You could fix this in fetcher.py line 67 by adding as e to the exception and from e at the end of the offending line. I think.

@willrogers
Copy link
Collaborator

The changes look pretty trivial so as long as they work I'm happy.

@aawdls
Copy link
Contributor Author

aawdls commented Sep 18, 2020

Yes I have tested it and seems to work OK.

@aawdls
Copy link
Contributor Author

aawdls commented Sep 18, 2020

Linter now happy. There is a problem with dependencies on python 2.7. I don't feel like looking into that right now.

@coveralls
Copy link

coveralls commented Sep 18, 2020

Coverage Status

Coverage increased (+0.3%) to 97.529% when pulling 7915458 on add-resume into a0cb320 on master.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 472

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 97.199%

Files with Coverage Reduction New Missed Lines %
aa/ca.py 2 93.18%
Totals Coverage Status
Change from base Build 467: -0.3%
Covered Lines: 590
Relevant Lines: 607

💛 - Coveralls

@willrogers
Copy link
Collaborator

I gave you dud advice. That 'fix' does break Python 2 and it was hidden by the dependency problem. At least I went back and checked.

I hope the branch I have force-pushed will pass.

@willrogers willrogers merged commit 3e89b9a into master Sep 18, 2020
@willrogers willrogers deleted the add-resume branch September 18, 2020 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants