-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add load_id
to _dlt_versions
table
#320
Comments
Hi @rudolfix thanks for opening this ticket 🙌 I recently ran into another use case wrt. schema version names: I wanted to identify which schema version was used for which load (i.e. the reverse of what you're describing above). Have you also considered adding the schema version to the |
why not? we can do it in this ticket. there will be duplicated information (you can always join the tables) but I assume it is more user friendly |
@tarunsamanta2k20 there was github outage and several copies of this ticket were created. glad to hear that you want to contribute! what kind of help do you need? |
@rudolfix I just filed a small PR for this, let me know what you think. Instead of adding the |
@codingcyclist thanks for the PR. I'll come back with the review soon |
Background
We want the users to be able to link the loads in
_dlt_loads
to_dlt_versions
to identify which load updated the schema without enabling the trace (https://dlthub.com/docs/running-in-production/running#inspect-and-save-the-load-info-and-trace).Tasks
load_id
into the_dlt_versions
, seeSqlJobClientBase
_dlt_versions
schema definition (schema/utils.py
) - make sure it is NULLABLE so old dlt installations can migrateschema/utils.py
)Tests
load_id
is stored (test_job_client.py
)The text was updated successfully, but these errors were encountered: