Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rest_api: rename json_response paginator to json_link #513

Closed
3 tasks done
burnash opened this issue Jun 27, 2024 · 0 comments
Closed
3 tasks done

rest_api: rename json_response paginator to json_link #513

burnash opened this issue Jun 27, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@burnash
Copy link
Collaborator

burnash commented Jun 27, 2024

Description

Currently, in the rest_api there are two paginators which use URL of the next page to paginate the results: json_response and header_link. json_response uses the next key in the JSON response, while header_link uses the Link header of the response.

Proposal

To be more consistent with the naming, and better reflect the actual functionality, we should rename the json_response paginator to json_link.

Task

  • Rename the json_response paginator to json_link in the rest_api module.
  • Update the doc in the dlt core repo
  • Update tests if needed

Related issues

dlt-hub/dlt#1495

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Ready for Deployment
Development

No branches or pull requests

2 participants