Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Quality of Life] Support spaces in dice string for bonuses, penalties #1

Closed
DLvalentine opened this issue Feb 22, 2019 · 2 comments
Closed

[Quality of Life] Support spaces in dice string for bonuses, penalties #1

DLvalentine opened this issue Feb 22, 2019 · 2 comments
Assignees
@DLvalentine
Labels
enhancement New feature or request

Comments

@DLvalentine
Copy link
Owner

Currently, only one long string is handled: 1d2+10

It would be nice to parse the string including spaces. 1d2 +10 -- note the space.
@DLvalentine DLvalentine added enhancement New feature or request good first issue Good for newcomers labels Feb 22, 2019
@DLvalentine DLvalentine self-assigned this Feb 22, 2019
@DLvalentine
Copy link
Owner Author

Spaces would make it easier to read, and will likely need to be handled as separate arguments.

@DLvalentine DLvalentine removed the good first issue Good for newcomers label Feb 22, 2019
@DLvalentine
Copy link
Owner Author

feex'd, though it blocks additional arguments for now.

Seeing as we don't have any, I'm not concerned. This can be resolved pretty easily later if we ever add any.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DLvalentine DLvalentine

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DLvalentine