Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: UI-Test (II) #634

Closed
18 tasks done
Tracked by #540
steffenkux opened this issue Oct 4, 2023 · 6 comments · Fixed by #636
Closed
18 tasks done
Tracked by #540

BUG: UI-Test (II) #634

steffenkux opened this issue Oct 4, 2023 · 6 comments · Fixed by #636
Assignees
Labels
bug Something isn't working

Comments

@steffenkux
Copy link
Contributor

steffenkux commented Oct 4, 2023

  • New Profile, first login -> configure profile -> wallet address (first line) is not shown (see (A))
  • Claim dm3 name works only the first time, then, claiming any name will fail (see (B))
  • When entering the name (dm3 name), pressing ENTER must click the button
  • validity check should be performed while input (not only after pushing the claim button. (Performance issue?)
  • red error message above input field(dm3 name) must not move the input component
  • the red should be the color defined in Figma (NOT pure red #ff0000)
  • When switching conversations, fetching messages should not have a overlay for the full component
  • Conversation context menu: sometimes (mostly first times), menu vanishes when I move the mouse to menu item
  • Menus should be below, if enough place is available (see (C))
  • address is shown, even when a dm3 name is set (see (D))
  • When add conversation is canceled, the menu must be closed, too.
  • Menu should open with animation (low prio)
  • The size of the component must not change when menu is opened
  • Edit message edits all messages (receiver still no published profile)
  • Delete message deletes all messages (receiver still no published profile), except a message with attachment
  • Line must go to the bottom always (see (E))
  • Seperator line in Input must be centered (see (F))
  • A deleted document must not have an attachment (see (G))

(A)
image
(B)
image
(C)
image
(D)
image
(E)
image
(F)
image
(G)
image

@Bhupesh-mfsi
Copy link
Collaborator

@hai-ko I have fixed all the UI related bugs. Three things are pending here:

  1. Claim dm3 name works only the first time ( This issue is same that I reported regarding DM3 name setting earlier ) (Backend)
  2. address is shown, even when a dm3 name is set ( Same reason, as DM3 name is not fetched from backend even when its set )(Backend)
  3. validity check should be performed while input ( I need a REGEX pattern for this )

@hai-ko
Copy link
Collaborator

hai-ko commented Oct 18, 2023

validity check should be performed while input (not only after pushing the claim button. (Performance issue?)

That function could be used to check the validity:

function validate(username) {
   return (
       username.length > 3 &&
       !username.includes('.') &&
       ethers.utils.isValidName(username)
   );
}

@Bhupesh-mfsi
Copy link
Collaborator

validity check should be performed while input (not only after pushing the claim button. (Performance issue?)

That function could be used to check the validity:

function validate(username) {
   return (
       username.length > 3 &&
       !username.includes('.') &&
       ethers.utils.isValidName(username)
   );
}

@hai-ko As per the above function the name cannot include "." But the ENS name could be like this "abcd.test.eth", so this is valid ENS name and here this logic won't work right?

@hai-ko
Copy link
Collaborator

hai-ko commented Oct 18, 2023

@hai-ko As per the above function the name cannot include "." But the ENS name could be like this "abcd.test.eth", so this is valid ENS name and here this logic won't work right?

This function is only for checking the user input in the claim text field. I want users only to claim one level lower than our user.dm3.eth suffix e.g. alice.user.dm3.eth and not bob.alice.user.dm3.eth. For all other places where an ENS name is used ethers.utils.isValidName() can directly be used

@hai-ko
Copy link
Collaborator

hai-ko commented Oct 18, 2023

For add conversation ethers.utils.isValidName() can be used

@Bhupesh-mfsi
Copy link
Collaborator

Perfect, thanks for the explaination

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants