Bitwarden_RS got renamed to vaultwarden

[dmaes]

dani-garcia renamed the project to dani-garcia/ vaultwarden ( see https://github.com/dani-garcia/vaultwarden/releases/tag/1.21.0 ). We should probably consider doing the same.

If we do this, we'll need to:

• Change the repository's name (rename or archive + create new ?)
• Change role name in Galaxy (or archive + create new)
• Change all variable names (and other occurrences of bitwardenrs) in the code to vaultwarden...
• Fix links to the vaultwarden GitHub repo

If we don't do this, we'll still need to fix all links.

I'm more a fan of archive + create new, except if GitHub and galaxy can redirect the old to the new, in case of a rename.

Thoughts @JensTimmerman ?

[JensTimmerman]

I just saw the vaultwarden rename, and I agree to also change the name of this project.

I prefer renaming the current one, this lets you keep a history of issues, releases, forks, stars etc...

If you are worried about having a 404 page on the current url, perhaps creating a new repo with the old name that's an archived clone of these repo is an option (Or just a readme with a link to the new name) (if github allows this, I think it does)

Same argument for galaxy.

I'll see if I have some time next week to look into updating all references in the code to vaultwarden.

[dmaes]

Just found out that GitHub should redirect old url to new url on name change. I'll change the name once code is updated then.

I don't immediately see how to change the name on Galaxy, but since that's tightly coupled to a GitHub repo, we'll see how it reacts to the name change on GitHub first then.

[JensTimmerman]

the rename gave some issues with the role, these have been fixed in https://github.com/dmaes/ansible-role-bitwardenrs/pull/13

more substantial fixes where everything is renamed to follow

[dmaes]

Changed all bitwardenrs occurences that I could find. Renamed github repo (old repo name successfully redirects). Role with new name on galaxy got automatically created by travis, will depcrecate the old role when all is done.
We could probably also change the vaultwarden_build_backend default to all 3 instead of the version-based default now (or even remove that option and always build for all 3 backends)

[JensTimmerman]

@dmaes the problem with changing everything is that this will break peoples upgrades,
you create a new user, with a new data dir, a new location for sqlite db, which will give people a brand new install of vaultwarden. losing access to all their passwords.

I was in the middle of creating a commit that also added a new var vaultwarden_user that could perhaps default to bitwarden_rs
, or even check if a bitwarden_rs user exists and then use that one but default to vaultwarden user if not?

[JensTimmerman]

actually you also create a new service, so running this role now will create a second new vaultwarden service and keep the old one running.

thinking about this, since this also happed with the repo change, and a new role on galaxy we could just document not to use the old deprecated one anymore, but it would entail some manual removal of the old users, old dirs, old services, and a manual migration to vaultwarden.

[dmaes]

I'll put some warnings and documentation in the README. I'll also create a new repo with the old name from the latest release, so the old role on galaxy doesn't point to the new repo. I'll add some warnings and stuff there too, so people have to knowingly switch to the new role and manually migrate their stuff and nothing suddenly breaks.

[JensTimmerman]

I think I needt this commands to make the migration of the db work: (the new user needs alter rights for bitwarden migrations)

GRANT bitwardenrs TO vaultwarden;