Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gmail shortcut links aren't delegated #27

Closed
treyharris opened this issue Sep 6, 2015 · 7 comments
Closed

Gmail shortcut links aren't delegated #27

treyharris opened this issue Sep 6, 2015 · 7 comments

Comments

@treyharris
Copy link

Google Gmail and Inbox both have shortcuts that let you visit a link an "Update" email references without opening the body of the message. In Gmail, for example, here's how some GitHub notifications look:
image

Clicking one of those Gmail buttons opens a new tab in the Epichrome SSB rather than launching the default browser.

In Inbox, blue callout links serve the same purpose as the Gmail buttons:
image

However, clicking these links do correctly open the default browser (or whatever other handling was assigned in the Epichrome extension).

Is there a way to make the Gmail buttons work as the Inbox ones do, too?

@dmarmor
Copy link
Owner

dmarmor commented Sep 15, 2015

Hi @treyharris,

Yeah, I have a gmail SSB and have noticed this same problem. It comes from the fact that those "View ..." buttons are not actually HTML links. They're javascript buttons that end up calling a link, so my usual link-handling logic doesn't catch them.

I've added this to my to-do list. I should be able to catch the new window when it opens and redirect as usual. (Not sure why it's not already doing it, to be honest, but when I get a chance I'll take a look.)

Thanks for the feedback!

Cheers,
DAve

@dmarmor dmarmor closed this as completed Jan 24, 2016
@dmarmor dmarmor reopened this Jan 24, 2016
@treyharris
Copy link
Author

This appears to potentially be fixed, at least for some GitHub quicklinks I just tried? I see you closed and reopened though, so maybe it's more subtle than that?

@dmarmor
Copy link
Owner

dmarmor commented Feb 15, 2016

Hmm. It still doesn't work right on my system. It's possible you have some different rules in your Epichrome Helper that allow it to work? If you have a moment, maybe you could export your rules and send them? (No hurry, since I won't have time to work on this for a while.)

@treyharris
Copy link
Author

Sure, this is all I've got:
image

@dmarmor
Copy link
Owner

dmarmor commented Feb 16, 2016

Hmm. Yeah, that doesn't look like it's doing anything fancy my rules aren't. Those little quicklinks are working for you, huh? I can't really figure that. They still don't work for me. I guess for now, let's not look a gift horse in the mouth, and I'll try to figure out what's going on when I've got some more time...

@treyharris
Copy link
Author

Are the quicklinks working for you now? Recently they've been okay for me, though I did need to adjust my custom rules a bit due to changes in Google's handling of Hangouts, now I have:

image

@dmarmor
Copy link
Owner

dmarmor commented Jun 13, 2016

Quicklinks still don't work for me! I did notice that in the current version of Chrome if I hit Cmd-N to open a blank tab, it sends that to my default browser! Chrome's tab-handling is a big mess, and seems to change version to version. I guess I'll close this issue for now, since it seems to work for you and nobody else is complaining (yet). Of course, reopen if anything changes...

@dmarmor dmarmor closed this as completed Jun 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants