Skip to content
This repository has been archived by the owner on Nov 9, 2017. It is now read-only.

add link to rails integration acme-authorizer #25

Closed
wireframe opened this issue Aug 1, 2016 · 4 comments
Closed

add link to rails integration acme-authorizer #25

wireframe opened this issue Aug 1, 2016 · 4 comments

Comments

@wireframe
Copy link

For Rails projects, this gem has been created to support sabayon:
https://github.com/betterup/acme-authorizer/

@dmathieu
Copy link
Owner

dmathieu commented Aug 1, 2016

Thank you Ryan. I'm afraid this won't work, as force_ssl adds a middleware at the top of any other one, and acme requests need to be handled without SSL.

See #18

@dmathieu
Copy link
Owner

dmathieu commented Aug 1, 2016

Also, I'd rather keep the README example simple and extensible.
Adding a gem to an application is not something trivial to do, and makes it harder to understand what the app needs to do.

@dmathieu dmathieu closed this as completed Aug 1, 2016
@wireframe
Copy link
Author

wireframe commented Aug 1, 2016

Thanks for the response @dmathieu. I'm the author of the acme-authorizer gem and have been using it w/ sabayon. For rails 4.x applications, the force_ssl can be configured in the application_controller.rb instead of config/application.rb and it allows for acme-authorizer to serve the challenge on HTTP.

from acme-authorizer docs:

NOTE: the ACME http-01 challenge/response must be served over HTTP without SSL. This means that your Rails application can not have the force_ssl flag set in your config/application.rb.

IMO as a ruby developer, a gem solution is preferable over copy-pasta code samples. Thanks for the work on sabayon and just wanted to offer this up to streamline other dev's time!

@dmathieu
Copy link
Owner

dmathieu commented Aug 1, 2016

Yes, but using force_ssl in the controller instead of the config is two very different things. One goes through the entire rails stack of middlewares, while the other does the redirection first.
We can't tell people to stop setting this in the configuration.

Thanks for the suggestion, it's appreciated. I wouldn't mind a phrase saying something like "you can also take a look at the acme-authorizer gem for a plug-and-play solution".

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants