Fix combo sequences that are not timing out #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -293,7 +293,7 @@ class keypress.Listener | |||
| # If we're working towards one, give them more time to keep going | |||
| clearTimeout(@_sequence_timer) if @_sequence_timer | |||
| if @sequence_delay > -1 | |||
| @_sequence_timer = setTimeout -> | |||
| @_sequence_timer = setTimeout => | |||
|
Is there a reason for |
|
It's been a while, but no I don't think I intended to remove it. I just
intended to re-generate it since the coffee script had changed.
…On Fri, Dec 2, 2016 at 12:10 AM, ClemensSchneider ***@***.***> wrote:
Is there a reason for keypress.js being removed from the repo with this
PR? Seems like the currently published version 2.1.4 is broke because it is
pointing to keypress.js as entry point which is now missing.. @dmauro
<https://github.com/dmauro>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#118 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AA62lrk6wgdZSSRoNotjkFckqiCzrfNSks5rD9J0gaJpZM4JM4sl>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value of "this" being used previously was bound to the window and not to the keypress listener.