Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SurrogateUnitBox not longer required for RBF? #41

Closed
fabrang opened this issue Jun 23, 2020 · 1 comment
Closed

SurrogateUnitBox not longer required for RBF? #41

fabrang opened this issue Jun 23, 2020 · 1 comment

Comments

@fabrang
Copy link

fabrang commented Jun 23, 2020

Just saw that my new docker image pulled your newest version. Normally i used to wrap the RBFInterpolant into the SurrogateUnitBox(model=RBFInterpolant()). Now SurrogateUnitBox doesn't exist anymore. Before my models where super bad without. Did you fix it now and it works without?

Thanks for your help
Cheers
Fabi

@dme65
Copy link
Owner

dme65 commented Jun 23, 2020

Hi Fabi, I have been observing the same thing so I enabled it by default. All surrogates are now internally scaling the data to the unit box, so you don't need to do it yourself. That will hopefully lead to better performance for the majority of cases.

@dme65 dme65 closed this as completed Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants