Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Density plots appear unexpectedly fuzzy #5

Closed
becnealon opened this issue Dec 2, 2019 · 3 comments
Closed

Density plots appear unexpectedly fuzzy #5

becnealon opened this issue Dec 2, 2019 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@becnealon
Copy link

becnealon commented Dec 2, 2019

Column density plots in plonk don't appear to show the same information as in splash? I plotted a broken disc and it looked fuzzier than I thought it should and despite adjustments it didn't improve. Have I missed something? It appears that high density structure in the inner region and the gap between the inner and outer disc are not accurately reproduced in plonk? See the examples attached below.

density_plonk.pdf
density_splash.pdf

Following the example in the wiki as much as possible, I plotted with:
viz = plonk.visualize.render(snap=snap,
quantity='density',
axis=axes,
extent=[-15,15,-15,15],
scalar_options={'cmap': 'gist_heat',
'norm': 'log',
'plot_colorbar': cbar}
)

I'm using:

  • OS: macOS 10.13.6
  • Python: Python 3.7.3, Anaconda with conda 4.7.12, using Jupyter notebook
  • Plonk version: 0.2.1
  • SPH code: Phantom, version c816ba88, gas only simulation.
@dmentipl
Copy link
Owner

dmentipl commented Dec 3, 2019

Hi @becnealon, thanks very much for the bug report.

It certainly looks like a bug. I'll have a look and get back to you.

@dmentipl dmentipl self-assigned this Dec 3, 2019
@dmentipl dmentipl added the bug Something isn't working label Dec 3, 2019
@dmentipl
Copy link
Owner

dmentipl commented Dec 7, 2019

I'm made some changes to the interpolation scheme that, I think, should fix your issue.

If you are happy to install Plonk from source (see https://github.com/dmentipl/plonk/blob/master/CONTRIBUTING.md) and can test with your data, that would be great. If not, and you're willing to share your snapshot with me, I can do the testing for you.

Please let me know how you'd like to proceed.

@becnealon
Copy link
Author

Hi @dmentipl, yes I've tested this and it has fixed my problem. Thanks!

@dmentipl dmentipl closed this as completed Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants