Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularization #21

Closed
Degubi opened this issue Nov 11, 2019 · 1 comment · Fixed by #22
Closed

Modularization #21

Degubi opened this issue Nov 11, 2019 · 1 comment · Fixed by #22

Comments

@Degubi
Copy link
Contributor

Degubi commented Nov 11, 2019

Add a module-info.java file to the source directory for the Java 9 module system.
I don't know which java version this library requires, but adding this file will require at least Java 9.
We need this module file, because without it it's very hard to create jlink images with this library.
The file should look something like this:

module shellinks {
    exports mslinks;
    exports io;
    exports mslinks.data;
    exports mslinks.extra;
}
  • This defines that the module name for the jar should be: "shellinks" (can change)
  • This means that all packages are exported (no encapsulation on package level).

I can create a PR for this if this is fine.

@DmitriiShamrikov
Copy link
Owner

Please create the PR. But please name the module the same way (mslinks)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants