-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Build] Failed to build labor sampling related code on windows_cu118 #6135
Comments
@mfbalin Hi, have you ever tried to build on windows with cuda? Do you have any ideas on the build error I posted above? |
Hi @Rhett-Ying, that line has a |
let me try this |
@mfbalin errors thrown with |
I agree, it might help. We can attempt to upgrade to c++17 again. |
let me try to update |
probably cuda driver needs to be updated as DeviceCopy was added 4 months ago. any ideas on this? @mfbalin |
latest status: #6139 (comment) |
As a conclusion, let's wait the CCCL release to see if could resolve this issue. For now CCCL is setting up windows CI: NVIDIA/cccl#248. |
I opened up an issue at the CCCL repository. NVIDIA/cccl#327 |
@Rhett-Ying The fix they made at the CCCL repository seems to have solved the issue. I can compile with the new CCCL |
I will open a PR updating to the new version, we don't have to merge it now. We can merge it when they officially announce the new release of CCCL. |
@mfbalin really appreciate your help on this. |
This issue has been automatically marked as stale due to lack of activity. It will be closed if no further activity occurs. Thank you |
@Rhett-Ying CCCL finally has a Windows CI, we can either wait for a new release, I don't know when that is though, or we can depend on the current head on the main branch that has Windows CI to fix the windows cuda compilation problems. |
Let's wait for a new release for now. If when we decide to cut a new release of DGL which incorporate this issue, let's depend on the head on the main branch to fix this issue. |
As mentioned in NVIDIA/cccl#327 (comment), CCCL 2.2 is ready. I will continue on this work item. |
You need to use this branch, their official release doesn't contain the fix for the build error we encountered. |
This issue has been automatically marked as stale due to lack of activity. It will be closed if no further activity occurs. Thank you |
🐛 Bug
To Reproduce
Builder: vs2019
Expected behavior
Environment
conda
,pip
, source):Additional context
The text was updated successfully, but these errors were encountered: