Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphBolt] Default value of persistent_workers should be False #6929

Open
Rhett-Ying opened this issue Jan 10, 2024 · 1 comment · May be fixed by #6932
Open

[GraphBolt] Default value of persistent_workers should be False #6929

Rhett-Ying opened this issue Jan 10, 2024 · 1 comment · May be fixed by #6932
Assignees
Labels
Work Item Work items tracked in project tracker

Comments

@Rhett-Ying
Copy link
Collaborator

🔨Work Item

IMPORTANT:

  • This template is only for dev team to track project progress. For feature request or bug report, please use the corresponding issue templates.
  • DO NOT create a new work item if the purpose is to fix an existing issue or feature request. We will directly use the issue in the project tracker.

Project tracker: https://github.com/orgs/dmlc/projects/2

Description

As gb.DataLoader inherits from torch.utils.data.DataLoader(https://pytorch.org/docs/stable/data.html#torch.utils.data.DataLoader), the default value of persistent_workers should be same. But for now, we're using True while torch uses False.

Depending work items or issues

@Rhett-Ying Rhett-Ying added the Work Item Work items tracked in project tracker label Jan 10, 2024
@Rhett-Ying Rhett-Ying added this to the 2023 12.30 Graphbolt milestone Jan 10, 2024
@Rhett-Ying Rhett-Ying changed the title [GraphBolt] [GraphBolt] Default value of persistent_workers should be False Jan 10, 2024
@Rhett-Ying Rhett-Ying self-assigned this Jan 10, 2024
@Rhett-Ying Rhett-Ying linked a pull request Jan 11, 2024 that will close this issue
8 tasks
@frozenbugs
Copy link
Collaborator

def __init__(self, datapipe, num_workers=0, persistent_workers=True):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Work Item Work items tracked in project tracker
Projects
Status: 🏠 Backlog
Development

Successfully merging a pull request may close this issue.

2 participants