Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up serialization logic #478

Closed
Tracked by #468
hcho3 opened this issue Apr 25, 2023 · 0 comments · Fixed by #507
Closed
Tracked by #468

Clean up serialization logic #478

hcho3 opened this issue Apr 25, 2023 · 0 comments · Fixed by #507
Labels

Comments

@hcho3
Copy link
Collaborator

hcho3 commented Apr 25, 2023

The current logic for serializer is a mess, with feeble attempt at abstraction. In particular, it's unclear what SerializeTemplate and DeserializeTemplate do, and why two copies of them exist in the header include/tree/tree.h.

We need a better abstraction for implementing common logic for PyBuffer and FILE serializers.

Also: we should use std::ostream / std::istream instead of FILE*. This way, we can seamlessly support serialization to in-memory strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant