You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current logic for serializer is a mess, with feeble attempt at abstraction. In particular, it's unclear what SerializeTemplate and DeserializeTemplate do, and why two copies of them exist in the header include/tree/tree.h.
We need a better abstraction for implementing common logic for PyBuffer and FILE serializers.
Also: we should use std::ostream / std::istream instead of FILE*. This way, we can seamlessly support serialization to in-memory strings.
The text was updated successfully, but these errors were encountered:
The current logic for serializer is a mess, with feeble attempt at abstraction. In particular, it's unclear what
SerializeTemplate
andDeserializeTemplate
do, and why two copies of them exist in the headerinclude/tree/tree.h
.We need a better abstraction for implementing common logic for PyBuffer and FILE serializers.
Also: we should use
std::ostream
/std::istream
instead ofFILE*
. This way, we can seamlessly support serialization to in-memory strings.The text was updated successfully, but these errors were encountered: