Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong plist is printed for the python package #5705

Closed
yurivict opened this issue May 25, 2020 · 6 comments · Fixed by #6362
Closed

Wrong plist is printed for the python package #5705

yurivict opened this issue May 25, 2020 · 6 comments · Fixed by #6362

Comments

@yurivict
Copy link

===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: %%PYTHON_SITELIBDIR%%/xgboost/lib/libxgboost.so
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: %%PYTHON_SITELIBDIR%%/libxgboost.so
===> Error: Plist issues found.
@yurivict
Copy link
Author

It shouldn't even reinstall libxgboost.so, it should use the pre-installed libxgboost.so

@trivialfis
Copy link
Member

Would you like to open a PR for checking system level installation?

@trivialfis
Copy link
Member

To resolve this, we need build flag in setup.py to let users decide whether do they want to reuse libxgboost.so in system path.

@merleyc
Copy link

merleyc commented Oct 16, 2020

Hi @trivialfis ,

I want to learn how to contribute to XGBoost so I'd like to be considered to work on this issue.
I know how to build the shared library:
... build]$ make -j$(nproc)
[ 14%] Built target dmlc
[ 20%] Built target rabit
[ 26%] Built target rabit_mock_static
Scanning dependencies of target objxgboost
[ 28%] Building CXX object src/CMakeFiles/objxgboost.dir/common/quantile.cc.o
[ 93%] Built target objxgboost
[ 94%] Linking CXX shared library ../../lib/libxgboost4j.so
[ 96%] Linking CXX executable ../xgboost
[ 97%] Built target runxgboost
[ 98%] Built target xgboost4j
[100%] Linking CXX shared library ../lib/libxgboost.so
[100%] Built target xgboost

How can I reproduce this issue? I don't get this issue even when I create a editable installation (python setup.py develop).

Thank you!

@trivialfis
Copy link
Member

trivialfis commented Oct 18, 2020

Sorry for the long wait. This is about using libxgboost.so from system paths like /usr/lib64/libxgboost.so instead of the shared library from source-path-to-xgboost/lib.

@trivialfis
Copy link
Member

This way, some packaging systems can avoid having 2 identical shared libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants