Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perform client-side validation on users form #113

Merged
merged 2 commits into from
Apr 15, 2021
Merged

Perform client-side validation on users form #113

merged 2 commits into from
Apr 15, 2021

Conversation

syucream
Copy link
Contributor

@syucream syucream commented Apr 10, 2021 •
edited
Loading

Relating to #110

Perform the minimum client-side validation on user create/edit forms without requesting to Django App. It should help users to know which's invalid:
image

@syucream syucream mentioned this pull request Apr 10, 2021
Closed
userlocalhost
userlocalhost approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@userlocalhost userlocalhost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!! I really appreciate for making measures against invalid input both frontend and server-side 👍

hinashi
hinashi approved these changes Apr 14, 2021
View reviewed changes
Copy link
Contributor

@hinashi hinashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@userlocalhost userlocalhost merged commit 4e97eac into dmm-com:master Apr 15, 2021
@syucream syucream deleted the clientside-validations-on-users-forms branch April 17, 2021 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@userlocalhost userlocalhost userlocalhost approved these changes

@hinashi hinashi hinashi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@syucream @userlocalhost @hinashi