Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs? #10

Closed
moll opened this issue Jul 11, 2016 · 4 comments
Closed

Tabs? #10

moll opened this issue Jul 11, 2016 · 4 comments
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@moll
Copy link

moll commented Jul 11, 2016

Hey,

Is it me or doesn't dedent support dedenting tabs?

Cheers

@dmnd
Copy link
Owner

dmnd commented Jan 28, 2017

I don't use tabs, but PRs welcome. Though I wonder what the expected behaviour is when tabs and spaces are mixed.

@moll
Copy link
Author

moll commented Jun 8, 2017

Presumably ignoring whichever wasn't at the start of the line would be sane behavior. :)

@adrianjost
Copy link
Contributor

Hi, I ran into the issue that this library still isn't supporting tabs. I did some research with the result that packages like outdent are handling tabs like a single space character. This makes the implementation really simple. In most cases there are no mixed spaces/tabs and if there are and we would handle tabs like spaces, we have an equally broken result as we would encounter with the current implementation (since spaces are trimmed, but tabs are still there).

I will try to implement this and open a pull request, if you are still fine with that @dmnd.

@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels May 22, 2023
@JoshuaKGoldberg
Copy link
Collaborator

Fixed by #28! 🎉

I'll try to release a beta version soon. #36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Development

No branches or pull requests

4 participants