Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swift objects are read and hashed in 4K chunks, using a lot of CPU #1

Closed
dmolesUC opened this issue Jan 11, 2019 · 1 comment
Closed

Swift objects are read and hashed in 4K chunks, using a lot of CPU #1

dmolesUC opened this issue Jan 11, 2019 · 1 comment

Comments

@dmolesUC
Copy link
Owner

Swift objects are read and hashed in 4K chunks, using a lot of CPU, and making the check process CPU-bound rather than IO-bound on fast connections.

This could be inherent to the Swift library we're using, or just Golang default behavior (see ncw/swift #132). But we can probably mitigate it by building up a larger slice before we pass it to the hash.
@dmolesUC
Copy link
Owner Author

Fixed in 2381830.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dmolesUC