Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.2.86 breaks with jest-environment-jsdom #79

Closed
anomiex opened this issue Oct 11, 2023 · 2 comments
Closed

Version 0.2.86 breaks with jest-environment-jsdom #79

anomiex opened this issue Oct 11, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@anomiex
Copy link

anomiex commented Oct 11, 2023

Describe the bug
When running tests using jest and jest-environment-jsdom, version 0.2.86 of this package causes a failure:

 FAIL  ./test.js
  ● Test suite failed to run

    Jest encountered an unexpected token

    Jest failed to parse a file. This happens e.g. when your code or its dependencies use non-standard JavaScript syntax, or when Jest is not configured to support such syntax.

    Out of the box Jest supports Babel, which will be used to transform your files into valid JS based on your Babel configuration.

    By default "node_modules" folder is ignored by transformers.

    Here's what you can do:
     • If you are trying to use ECMAScript Modules, see https://jestjs.io/docs/ecmascript-modules for how to enable it.
     • If you are trying to use TypeScript, see https://jestjs.io/docs/getting-started#using-typescript
     • To have some of your "node_modules" files transformed, you can specify a custom "transformIgnorePatterns" in your config.
     • If you need a custom transformation specify a "transform" option in your config.
     • If you simply want to mock your non-JS modules (e.g. binary assets) you can stub them out with the "moduleNameMapper" config option.

    You'll find more details and examples of these config options in the docs:
    https://jestjs.io/docs/configuration
    For information about custom transformations, see:
    https://jestjs.io/docs/code-transformation

    Details:

    /tmp/test/node_modules/lib0/webcrypto.js:3
    export const subtle = crypto.subtle
    ^^^^^^

    SyntaxError: Unexpected token 'export'

      3 |  */
      4 |
    > 5 | const random = require( 'lib0/random' );
        |                ^
      6 |
      7 | test( 'it works', () => {
      8 |     const element = document.createElement('div');

      at Runtime.createScriptFromCode (node_modules/jest-runtime/build/index.js:1505:14)
      at Object.<anonymous> (node_modules/lib0/dist/random.cjs:7:17)
      at Object.require (test.js:5:16)

Test Suites: 1 failed, 1 total
Tests:       0 total
Snapshots:   0 total
Time:        0.325 s

It worked with 0.2.85.

To Reproduce
Steps to reproduce the behavior:

  1. Create an empty directory for the test.
  2. Run npm add jest jest-environment-jsdom lib0
  3. Create the following file named test.js:
    /**
     * @jest-environment jsdom
     */
    
    const random = require( 'lib0/random' );
    
    test( 'it works', () => {
        const element = document.createElement('div');
        expect( element ).not.toBeNull();
    } );
  4. Run npm exec jest test.js
  5. See error

Expected behavior
Test passes, along the lines of

 PASS  ./test.js
  ✓ it works (2 ms)

Test Suites: 1 passed, 1 total
Tests:       1 passed, 1 total
Snapshots:   0 total
Time:        0.379 s

Environment Information

  • Node.js
  • Which version are you using? v18.17.1

Additional context
The cause is 4b4faaa. With jest-environment-jsdom the conditions available are "browser", "require" (not "import"), and "default", but that commit assumes "browser" always comes with "import".

A detailed analysis of a similar problem in another package, along with potential workarounds, may be found at microsoft/accessibility-insights-web#5421 (comment).

@anomiex anomiex added the bug Something isn't working label Oct 11, 2023
@dmonad dmonad closed this as completed in 72b9ed5 Oct 13, 2023
@dmonad
Copy link
Owner

dmonad commented Oct 13, 2023

This should be fixed in the next release. Please reopen the ticket if the issue persists.

@anomiex
Copy link
Author

anomiex commented Oct 13, 2023

It works, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants