Skip to content
This repository has been archived by the owner on Oct 3, 2024. It is now read-only.

[AppNavigation] [Tabs] - new listener is added on tabsRouters despite some routers already have a listener #30

Closed
DMouayad opened this issue Oct 10, 2023 · 0 comments · Fixed by #31
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@DMouayad
Copy link
Owner

DMouayad commented Oct 10, 2023

Description:

  • Because adding a new tab results in creating a new GoRouter instance and we need to listen to changes on this router:
    a new listener is added for every tab-router even if we already added a listener on it.
  • Current implementation removes the listener before adding a new one but it seems to not have any effect i.e. doesn't remove existing listener.

Suggestions:

  • create a list of keys, each key belongs to a GoRouter instance.
  • we acquire the keys from the object hashCode.
@DMouayad DMouayad added the bug Something isn't working label Oct 10, 2023
@DMouayad DMouayad self-assigned this Oct 10, 2023
@DMouayad DMouayad moved this to In Progress in Dune Board Oct 10, 2023
@DMouayad DMouayad added the good first issue Good for newcomers label Oct 10, 2023
@DMouayad DMouayad changed the title [AppNavigation] [Tabs] - new listener is added on every tabsRouters despite some routers have listeners [AppNavigation] [Tabs] - new listener is added on every tabsRouters despite some routers already have a listener Oct 10, 2023
@DMouayad DMouayad changed the title [AppNavigation] [Tabs] - new listener is added on every tabsRouters despite some routers already have a listener [AppNavigation] [Tabs] - new listener is added on tabsRouters despite some routers already have a listener Oct 10, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Dune Board Oct 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant