failure with special chars in paths

[Flow86]

Hi,

I'm using Redfish-Mockup-Creator on windows, trying to read a dell poweredge system. The poweredge system contains paths like
/redfish/v1/Systems/System.Embedded.1/Storage/RAID.Integrated.1-1/Drives/Disk.Bay.7:Enclosure.Internal.0-1:RAID.Integrated.1-1 (note the : in there!)

Writing these files to disk on windows fails.
Is there a way to modify the file downloads to have "safe" filenames? (i.e replace any special char with an underscore)

Thank you

[mraineri]

That should be a good addition; most of the testing I do is under Linux, which doesn't have that limitation. We'll review the list of disallowed characters for folder names that are allowable in URIs and make a list of characters to replace.

[Flow86]

I have encountered at least these three: | : ?

[mraineri]

@Flow86 please try out the branch "special-character-handling"; this change should detect the naming restrictions automatically so you do not need to specify anything new on the command line. From the systems I have available and running on Windows, this seems to address the issue.

[Flow86]

Hi,
I've tested it on a few of my systems and it works. Thank you, thats great!

[mraineri]

Thanks for confirming! It'll likely get merged later today so it's part of the main release.

[jautor]

We'll also open an issue in the Redfish-Service-Validator to throw a warning if it sees these characters in URIs. While they are "legal" from the RFC and Redfish Specification perspective, they should be discouraged...