Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer dependency warning #500

Closed
oliviertassinari opened this issue Nov 15, 2020 · 5 comments · Fixed by shadoo77/cv-creator#8
Closed

Peer dependency warning #500

oliviertassinari opened this issue Nov 15, 2020 · 5 comments · Fixed by shadoo77/cv-creator#8

Comments

@oliviertassinari
Copy link

oliviertassinari commented Nov 15, 2020

When installing @material-ui/lab@v5.0.0-alpha.16 with date-fns, a developer gets the following warnings:

warning "@material-ui/lab > @date-io/dayjs@2.10.6" has unmet peer dependency "dayjs@^1.8.17".
warning "@material-ui/lab > @date-io/luxon@2.10.6" has unmet peer dependency "luxon@^1.21.3".
warning "@material-ui/lab > @date-io/moment@2.10.6" has unmet peer dependency "moment@^2.24.0".

Is there a way we could solve them? cc @eps1lon.

I'm using yarn v1.22.4.

@oliviertassinari oliviertassinari changed the title Peer dependency Peer dependency warning Nov 15, 2020
@eps1lon
Copy link

eps1lon commented Nov 16, 2020

We already solved this for the package managers that can solve them (yarn 2 and npm 6) with peerDependenciesMeta. We can close this if you can't reproduce them with yarn 2. For yarn 1 only we can close this issue.

Either way, it's not an issue for date-io but the packages depending on date-io. In this case: @material-ui/lab.

@oliviertassinari
Copy link
Author

oliviertassinari commented Nov 16, 2020

Regarding npm 7, there are no warnings when installing @material-ui/lab :). However, it installs all the peer dependencies. You have date-fns, moment, luxon, and dayjs in the package-lock and node_modules.


I think that we should be careful optimizing for yarn 2. As far as I understand it, it's still unclear if it won't create another Python 2 vs. Python 3. Yarn 2 adoption seems slow even with yarn 1 under a subdomain:

Capture d’écran 2020-11-16 à 11 55 00

https://www.similarweb.com/website/yarnpkg.com/?competitors=classic.yarnpkg.com

@eps1lon
Copy link

eps1lon commented Nov 16, 2020

I think that we should be careful optimizing for yarn 2.

We're not.

@dmtrKovalenko
Copy link
Owner

Sorry, I completely missed this issue 😞

The fix is available in v2.10.8. Make sure that you need to manually update and lock the version

@oliviertassinari
Copy link
Author

Great, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants