Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crabID should be a number #5860

Closed
belforte opened this issue Mar 30, 2019 · 7 comments
Closed

crabID should be a number #5860

belforte opened this issue Mar 30, 2019 · 7 comments

Comments

@belforte
Copy link
Member

now it is a string to accomodate automatic splitting numberingof probes as 0-1 ... 0-5
and tails as 30-1...30-99 etc.
But for proper sorting in Grafana we need a number

@lecriste
Copy link
Contributor

Since CRAB code is full of such condition looking for the Automatic splitting - symbol in the job number:
https://github.com/dmwm/CRABClient/blob/master/src/python/CRABClient/Commands/status.py#L542

I propose to convert the current string to a number only in the Benjamin script:
https://github.com/dmwm/cms-htcondor-es/blob/master/src/htcondor_es/convert_to_json.py#L30

@belforte if you agree I will create an issue there and follow up with Christian to understand which is the best conversion for Grafana.

@belforte
Copy link
Member Author

Good idea Leo. makes a lot of sense to me.
Let's make sure that @stiegerb also likes it and then we go. I meet with Christian on monday morning, can surely ask about this.

@stiegerb
Copy link

stiegerb commented Apr 1, 2019

We just changed CRAB_Id to be treated as a string, so I would suggest to just create a new field that can be used for sorting.

But I don't fully understand the problem. This is about sorting entries in a table in Grafana? It can't do that with a string?

@belforte
Copy link
Member Author

belforte commented Apr 1, 2019 via email

@lecriste
Copy link
Contributor

lecriste commented May 6, 2019

@lecriste lecriste closed this as completed May 6, 2019
@belforte
Copy link
Member Author

belforte commented May 6, 2019

@lecriste that does not look like the correct reference

@lecriste
Copy link
Contributor

Moved to dmwm/cms-htcondor-es#118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants