documet Jenkins commands via GH comments

[belforte]

we ca issue a few commands to Jenkins via GH comments, e.g.
"test this please" forces (re-)running of Pull Request checks.

Things to do

• find where those commands are defined
• document
• look into adding more "variants" so that e.g. we can use also "please test" or "test this" or similar w/o need to remember exact wording. Jenkings running in CMSSW repo alrady allows this

[mapellidario]

From a first quick look at this request, I do not think this is easily achievable.

The bot that takes care of cmssw PR, such as this one is cmsbuild, whose code i suppose is available at cms-sw/cmsbuild. In particular, I assume that the message used to trigger the test is this one.

The bot that takes care of WMCore and CRAB* repos is cmsdmwmbot and based on his profile picture I suspect that it is the default Jenkins Pull Request Builder. Here it is mentioned that the sentence test this please is used "for a one time test run".
My suspect is reinforced also by reading Alan's documentation of WMCore jenkins pipeline, in which only the sentence test this please is mentioned to trigger the tests.

Please, notice that in our jenkins setup, for many DMWM-WMCore-* jobs, there are the equivalent DMWM-CRABServer-* and DMWM-CRABClient-* ones, so I suspect that what Alan wrote about WMCore, is also true for CRABServer/CRABClient.

If we want flexibility in the words used to trigger our jenkins build, I suspect that we need a new bot that understands a new set of sentences, that then triggers the jenkins job. I am not sure it is worth the effort.

As always @belforte, these are my suppositions from taking a look around, but if you are sure that something is wrong, please don't hesitate to point it out! In any case, we can always ask Shahzad and/or Alan for help!

[belforte]

thanks for diffing @mapellidario . Indeed I thought that the two robots were closer than they are. I agree that lacking an already existing setup to accept custom commands, it is not worth to introduce it for this. Let's stick with test this please and try to remember/document it.

[mapellidario]

Let's stick with test this please and try to remember/document it.

sounds good! I would leave open this PR until I write a (brief?) twiki page that explains a bit our jenkin setup, similar to Alan's wiki.

[belforte]

we already have this https://github.com/dmwm/CRABServer#readme about Jenkins. I am OK with moving to twiki, but also with using GH more for documentation. If we keep Jenkins instructions in GH, let's make sure that we point to that in twiki as well. Indeed our twilki is quite old and too big, may use a big cleanup...

[mapellidario]

Indeed our twilki is quite old and too big, may use a big cleanup...

+1!

I know we have already something written about how we build and deploy images, but in order to refactor our pylint setup i had to dig it out of my memory from the WMCore days. That is what I would write some lines about, so that even you or wa could replicate it without loosing to much time wondering around github/gitlab/jenkins.

I can write this in in a twiki or in a GH wiki, wherever you like, i don't have any preference.

[mapellidario]

Stefano found https://github.com/dmwm/CRABServer/wiki/CRAB-Testing and it contains pretty much all of the information that I wanted to write down in the new twiki.

I think there is not much we can add on this topic and I propose to close this issue.

(Of course, we will need to create a consistent set of documentation so that we do not have such (albeit pleasant!) surprises in the future, but this is a different topic)

[belforte]

Dario, please add to the wiki the instruction on how to trigger PR test via a comment, and then close this. thanks.

[mapellidario]

I just added https://github.com/dmwm/CRABServer/wiki/CRAB-Testing#jenkins---github-integration, so I will close this issue.