Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support campaign name for RERECO workflows #11704

Closed
khurtado opened this issue Sep 7, 2023 · 2 comments · Fixed by #11710
Closed

Support campaign name for RERECO workflows #11704

khurtado opened this issue Sep 7, 2023 · 2 comments · Fixed by #11710

Comments

@khurtado
Copy link
Contributor

khurtado commented Sep 7, 2023

Impact of the new feature
Support the campaign names available in de workflow description for RERECO workflows.

Is your feature request related to a problem? Please describe.
It is related to: #10914

Describe the solution you'd like
For a RERECO workflow, we only have one campaign name set in the Workload and task level (WMTask). We need need to propagate this information at the job classad level (JobCreator and JobSubmitter) so that this information is part of the pickle file we send to the job submitter and create a new condor classad with it. Monit script also need to be modified so that we use this information only when the value is meaningful (not Unknown/Undefined), or fallback to the current inference of the campaign name otherwise.

If the campaign information is available for the JobSubmitter componen:

  • CMS_Campaign: a string with the campaign name which the job belongs to.

Describe alternatives you've considered
Use current mechanism at monit level, which we want to change now.

Additional context
Child of #10914

@amaltaro
Copy link
Contributor

amaltaro commented Sep 8, 2023

@khurtado while investigating the FJR code, I just happened to find this line of code:
https://github.com/dmwm/WMCore/blob/4170e4a/src/python/WMCore/JobStateMachine/ChangeState.py#L352

which is executed by the JobAccountant component.

If we indeed migrate the campaign to be an attribute of a task instead of the workload, we need to keep in mind to update that line as well.

@khurtado
Copy link
Contributor Author

khurtado commented Sep 8, 2023

@amaltaro Good catch, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment