Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GH action to build/push docker image #11651

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

amaltaro
Copy link
Contributor

@amaltaro amaltaro commented Jul 7, 2023

Fixes #11646

Status

not-tested

Description

Fix - hopefully - bug introduced with: #11638

The last step in the docker workflow (re)tries to build the image once again, so we need to ensure that the expected TAG is set in there as well.

I was going to upgrade the GH action container to v4, but I am not 100% confident with the necessary changes. I think it would be a matter of:

-          repository: cmsweb/${{inputs.wmcore_component}}
+          tags: cmsweb/${{inputs.wmcore_component}}:${{steps.get-ref.outputs.tag}}

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

Bug introduced with #11638

External dependencies / deployment changes

None

@amaltaro
Copy link
Contributor Author

amaltaro commented Jul 7, 2023

Bypassing Jenkins, sorry!

@amaltaro amaltaro merged commit 8647003 into dmwm:master Jul 7, 2023
@amaltaro
Copy link
Contributor Author

amaltaro commented Jul 7, 2023

And it fails! Apparently in the v1 the argument name has a dash sign instead of underscore(!!!!!)

Warning: Unexpected input(s) 'build-args', valid inputs are ['entryPoint', 'args', 'username', 'password', 'registry', 'repository', 'tags', 'tag_with_ref', 'tag_with_sha', 'path', 'dockerfile', 'target', 'always_pull', 'build_args', 'cache_froms', 'labels', 'add_git_labels', 'push']

I will give the v4 a try!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build docker images using the build arguments instead of sed'ing Dockerfile
1 participant