Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename build_args in GH action workflow #11652

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

amaltaro
Copy link
Contributor

@amaltaro amaltaro commented Jul 7, 2023

Fixes #11646

Status

not-tested

Description

The argument name in the v1 container is actually build_args, not build-args (as it is expected in the v4).

Is it backward compatible (if not, which system it affects?)

YES

Related PRs

Fix #11638 and #11651

External dependencies / deployment changes

None

@amaltaro amaltaro merged commit 07fc3fe into dmwm:master Jul 7, 2023
@amaltaro
Copy link
Contributor Author

amaltaro commented Jul 8, 2023

And this one also failed for reqmgr2ms-unmerged dockerfile, all the others succeeded. Error was at the "Publish to registry" step with error message:

Step 10/22 : RUN curl -ksLO https://raw.githubusercontent.com/dmwm/WMCore/$TAG/requirements.txt
 ---> Running in 2031079ad032
The command '/bin/sh -c curl -ksLO https://raw.githubusercontent.com/dmwm/WMCore/$TAG/requirements.txt' returned a non-zero code: 3
Error: exit status 3
Usage:
exit status 3
  github-actions build-push [flags]

Flags:
  -h, --help   help for build-push

where $TAG should have been properly expanded, otherwise it would have failed in the Build step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build docker images using the build arguments instead of sed'ing Dockerfile
1 participant