Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Swift 5] Use BinaryInteger.isMultiple(of:) #29

Closed
jsbean opened this issue Aug 31, 2018 · 0 comments · Fixed by #36
Closed

[Swift 5] Use BinaryInteger.isMultiple(of:) #29

jsbean opened this issue Aug 31, 2018 · 0 comments · Fixed by #36
Labels

Comments

@jsbean
Copy link
Member

jsbean commented Aug 31, 2018

Currently, there exists here BinaryInteger.isDivisible(by:), upon which .isEven and .isOdd are implemented.

With SE-0225, BinaryInteger.isMultiple(of:) will exist in the stdlib. Use this instead, for the reasons used in the review.

This will only be applicable as of Swift 5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant