Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme: Color Window Caption when is window is inactive #513

Closed
Csavie opened this issue Jun 18, 2021 · 11 comments
Closed

Theme: Color Window Caption when is window is inactive #513

Csavie opened this issue Jun 18, 2021 · 11 comments

Comments

@Csavie
Copy link
Contributor

Csavie commented Jun 18, 2021

Hi,

First of all, congratulations for this great software, and thanks for make it open source.

I did a new theme, with colours more Windows XP style.

WinXPColors

But I can't change the colour of window caption when the window of program is inactive. In [theme].xaml I not see the something like "Caption.Background.Inactive" and "Caption.Foreground.Inactive" . Really it doesn't exists?.

In Light or Dark themes neither are difference between window is active or not. It's very annoying because without this functionality, the window of program seems is always active in my theme or inactive in default themes.

Many thanks in advance,

Csavie

WinXPColors.zip

@doug24
Copy link
Contributor

doug24 commented Jun 18, 2021

I don't know if you are the first to create or modify a theme, but I'm pretty sure you're the first to post one back here - thanks!

Yes, I can add "Caption.Background.Inactive" and "Caption.Foreground.Inactive" - they don't exist now.

@Csavie
Copy link
Contributor Author

Csavie commented Jun 18, 2021

Thanks for add it !!, i will wait for a new version.

Csavie

@doug24
Copy link
Contributor

doug24 commented Jun 27, 2021

Added in Release 2.9.345

@doug24 doug24 closed this as completed Jul 4, 2021
@Csavie
Copy link
Contributor Author

Csavie commented Jul 6, 2021

Hi,

Thanks for add it, it works perfectly.

I let here the new theme for if someone is interested.
WinXPColors Ver 2.9.345.zip

Csavie.

@doug24
Copy link
Contributor

doug24 commented Feb 11, 2024

@Csavie - are you still using and maintaining your theme?

In the February release of dnGrep (next week) I made two breaking changes to the theme files:

  1. The key "GradientBackground" is changed to "Window.Background"

  2. The Pin and Unpin bitmaps have been removed from the theme file and replaced with this:

    <sys:Boolean x:Key="ToggleButton.DarkImages">true</sys:Boolean>

set it to false for light-colored themes.

I have a Theme Editor on my personal page - it is an update of what I used to create the original themes - not complete, but is useful. You can use/edit the same file in the same location for both the Theme Editor and dnGrep.

@Csavie
Copy link
Contributor Author

Csavie commented Feb 13, 2024 via email

@Csavie
Copy link
Contributor Author

Csavie commented Feb 25, 2024 via email

@doug24
Copy link
Contributor

doug24 commented Feb 25, 2024

If you intended to attach a new theme file here, it didn't work. You probably need to attach it from the github website as a zip file (not from an email reply).

I will add the new color for the caption buttons. While I'm doing that, I will make a couple of other changes to the themes - fix two misspellings, change a few keys, and add a couple of other new colors. I will post all the changes together when it is finalized.

@Csavie
Copy link
Contributor Author

Csavie commented Feb 26, 2024

Ok, perfect, thanks for it, I will wait.

Csavie

@doug24
Copy link
Contributor

doug24 commented Mar 6, 2024

@Csavie I just published a new release of the Theme Editor with lots of changes. These changes will be release in dnGrep in the March release next week.

See this discussion topic for a full list of changes to the theme files - you can either edit your theme with the new editor, or merge in changes from one of the theme files included in the release package. You will not be able to view the changes in dnGrep until after the March 2024 release next week.

I'll update the Readme file on the main Theme Editor page soon.

@doug24
Copy link
Contributor

doug24 commented Mar 6, 2024

Just wanted to add that you need to make the key name changes and add the new color elements to your theme file manually before opening it in the theme editor - it will not add the missing colors or fix the keys for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants