Issue #277 utf-8 byte order mark

[doug24]

Issue #277 change to keep original file utf-8 bom. Also fixed a problem where the "replace" added an extra new line to files that did not end with a new line.

I believe this fixes the current problem, but we could use more tests for replace on files with different encodings.

For Issue #210, added an additional fix for regex replace, where the regex contains a $ token. The $ (end of line) token will only match UNIX new line character, so Windows and Mac new lines must be converted to the UNIX new line before calling the replace method.

[JVimes]

I'll take a look as soon as I can. Thanks!

[JVimes]

ReSharper got me in the habit of "invert if-statement to reduce nesting", which I've found I really like. Makes the code easier to follow. What do you think about something like this?

public static bool HasUtf8ByteOrderMark(Stream inputStream)
{
    int bb = inputStream.ReadByte();
    if (0xEF != bb) return false;
    bb = inputStream.ReadByte();
    if (0xBB != bb) return false;
    bb = inputStream.ReadByte();
    if (0xBF != bb) return false;
    inputStream.Seek(0, SeekOrigin.Begin);
    return true;
}

[doug24]

Yes, except the input stream needs to be reset to the origin on any return condition. How about getting rid of the if-statements all together?

        public static bool HasUtf8ByteOrderMark(Stream inputStream)
        {
            int b1 = inputStream.ReadByte();
            int b2 = inputStream.ReadByte();
            int b3 = inputStream.ReadByte();
            inputStream.Seek(0, SeekOrigin.Begin);

            return (0xEF == b1 && 0xBB == b2 && 0xBF == b3);
        }

[JVimes]

Oh, that's it! That's a winner. 😸

[majkinetor]

Thanks for quickly looking into this.