Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

installation wasn't a pleasant experience #48

Open
rchikhi opened this issue Jun 24, 2020 · 2 comments
Open

installation wasn't a pleasant experience #48

rchikhi opened this issue Jun 24, 2020 · 2 comments

Comments

@rchikhi
Copy link

rchikhi commented Jun 24, 2020 •
edited
Loading

Hi, I very much look forward to use dashing, however three small issues with how it is distributed made me lose some time during installation:

  1. source code is huge due to its dependencies, took me more than 10mins to git clone
  2. releases didn't work on my (old) cluster, so I needed to build from source. Could you please provide more portable binaries?
  3. bioconda install worked :) but it wasn't mentioned on the README. EDIT: ahh I take it back, there is a badge! I didn't see it
@dnbaker
Copy link
Owner

dnbaker commented Jun 25, 2020

Hi,

Thanks for the feedback!

You're right that recursive submodules can take a long time, which is something we're looking to improve without making dependency management too difficult.

Good to know RE: binary releases; Outside of manual static compilations, the only standard solution for cross-platform binary distribution I'm aware of is Holy Build Box, but it was restricted to gcc4 last I checked. I'll try to find a better method for distribution.

Glad bioconda worked! I'll update installation instructions to make it clearer that it is an option.

Thanks again,

Daniel

@rchikhi
Copy link
Author

rchikhi commented Jun 25, 2020

thanks for the response!
Maybe the CI's like Travis/CircleCI/Github actions?

@dnbaker dnbaker mentioned this issue Aug 26, 2020
Merged
dnbaker added a commit that referenced this issue Aug 26, 2020
@dnbaker
Dependency (#54)
5210548 
1. Includes components with external submodules directly for faster installation. (Response to [this issue](#48).)
2. Provides error messages for sketch finalization, including an update to the sketch library for saner defaults when Shrivastava-style densification of empty sketches. (Addresses [this issue](#53).)
3. Cosmetic updates, CLI. See commits below.

* Minor cosmetic updates --
Ensure that ##Names are only emitted when necessary
Add const
Added error message for ZlibError
Ensure that -W has the same behavior as --cache-sketches

* Error checking during sketch_finalize
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rchikhi @dnbaker