--parse-by-seq bug fix + orderminhash bug fix #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnbaker
added a commit
that referenced
this pull request
Mar 7, 2024
* Debug --parse-by-seq lazily spilling to disk. * Additionally update bonsai + hll versions for orderminhash bug fix. * Free memory if possible for --seqs-in-ram mode. * Manually manage versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since --parse-by-seq only needs sequences for edit distance calculation, we can free memory if running in --seqs-in-ram mode. Saves the trouble of caching the parsed sequences to disk, but requires more memory.
Lifetime management needed a bit of extra work, but it seems to be stable for both cases.